Fabiano Fidêncio
bdb94fa35b
dragonball: Allow question_mark warning in allocate_device_resources()
...
As the rust toolchain version bump to its 1.66.0 release raised a
warning about the code being able to be refactored to use `?`.
For now that's something we don't need to change, so let's ignore such
warning in this very specific case.
See:
https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 16:37:24 +01:00
Fabiano Fidêncio
c7eb516bc0
dragonball: Fix unnecessary_cast warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to unnecessary_cast.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 16:37:24 +01:00
Fabiano Fidêncio
1085fac5c2
agent: Allow clippy::question_mark warning in Namespace{}
...
As the rust toolchain version bump to its 1.66.0 release raised a
warning about the code being able to be refactored to use `?`.
For now that's something we don't need to change, so let's ignore such
warning in this very specific case.
See:
https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:34:02 +01:00
Fabiano Fidêncio
c3c9e1b4a3
agent: Fix explicit_auto_deref warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to explicit_auto_deref.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:33:58 +01:00
Fabiano Fidêncio
20be612cd1
agent: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:33:53 +01:00
Fabiano Fidêncio
083e3f26ed
rustjail: Fix unnecessary_cast warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to unnecessary_cast.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:33:48 +01:00
Fabiano Fidêncio
1f391ef511
rustjail: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:33:40 +01:00
Fabiano Fidêncio
bc71ca0d73
kata-types: Fix unnecessary_cast warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to unnecessary_cast.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:33:33 +01:00
Fabiano Fidêncio
ac4c0ff9d6
kata-types: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:33:29 +01:00
Fabiano Fidêncio
036e82a164
safe-path: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:33:23 +01:00
Fabiano Fidêncio
4b4ecd0cba
kata-sys-util: Fix "match-like-matches-macro" warning
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to "match-like-matches-macro".
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:33:13 +01:00
Fabiano Fidêncio
c16c1bde86
kata-sys-util: Fix unnecessary_cast warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to unnecessary_cast.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:33:08 +01:00
Fabiano Fidêncio
021201005d
kata-sys-util: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:33:01 +01:00
Fabiano Fidêncio
716b22a458
logging: Allow clippy::type-complexity warning
...
As the rust toolchain version bump to its 1.66.0 release raised a
warning about the type complexity used for the closure, and that's
something we don't want to change, let's ignore such warning in this
very specific case.
See:
https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:32:52 +01:00
Fabiano Fidêncio
738d2d9736
logging: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:32:47 +01:00
Fabiano Fidêncio
869b9d15a8
protocols: Fix unnecessary_cast warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to unnecessary_cast.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:32:30 +01:00
Fabiano Fidêncio
eda857d898
protocols: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:31:12 +01:00
Steve Horsman
769f91de8b
Merge pull request #5933 from Megan-Wright/CCv0
...
CC: Merge main into CCv0 branch
2022-12-21 13:35:57 +00:00
stevenhorsman
3ef2fd1784
runtime: Update the remote hypervisor config
...
Add the SELinux setting to ensure it is passed through to the remote
hypervisor
Fixes : #5936
Signed-off-by: stevenhorsman <steven@uk.ibm.com >
2022-12-20 13:11:54 +00:00
Megan Wright
e2341c1b33
CCv0: Merge main into CCv0 branch
...
Merge remote-tracking branch 'upstream/main' into CCv0
Fixes : #5932
Signed-off-by: Megan Wright <megan.wright@ibm.com >
2022-12-20 09:34:27 +00:00
Bin Liu
0cf443a612
Merge pull request #5915 from openanolis/legacy_device
...
dragonball: refactor legacy device initialization
2022-12-19 13:31:45 +08:00
Fabiano Fidêncio
1ee684021d
Merge pull request #5906 from GeorginaKin/CCv0
...
CCv0: Merge main into CCv0 branch
2022-12-17 22:31:45 +01:00
Bin Liu
e4645642d0
Merge pull request #5877 from openanolis/fix_start_bundle
...
runtime-rs: enable start container from bundle
2022-12-17 08:10:08 +08:00
Steve Horsman
e217628eb5
Merge pull request #5581 from dubek/sev-es-launch-digest
...
CCv0: runtime: pkg/sev: Support SEV-ES launch digest calculation
2022-12-16 11:38:45 +00:00
Georgina Kinge
05311ffa37
runtime: Add disable_guest_selinux to CCv0
...
Adding blocks for disable_guest_selinux to extra CCv0 files.
Signed-off-by: Georgina Kinge <georgina.kinge@ibm.com >
2022-12-15 15:03:07 +00:00
Yushuo
d14c3af35c
dragonball: refactor legacy device initialization
...
If the serial path is given, legacy_manager should create socket console
based on that path. Or the console should be created based on stdio.
Fixes : #5914
Signed-off-by: Yushuo <y-shuo@linux.alibaba.com >
2022-12-15 20:55:01 +08:00
Zhongtao Hu
ca39a07a14
runtime-rs: enable start container from bundle
...
enable start container from bundle in this way
$ ls ./bundle
config.json rootfs
$ sudo ctr run -d --runtime io.containerd.kata.v2 --config bundle/config.json test_kata
Fixes:#5872
Signed-off-by: Zhongtao Hu <zhongtaohu.tim@linux.alibaba.com >
2022-12-15 17:28:13 +08:00
Peng Tao
ebb73df6bc
Merge pull request #5899 from Bevisy/fix-outdated-comments
...
shim: return hypervisor's pid not shim's pid
2022-12-15 14:55:54 +08:00
Chao Wu
fad229b853
Merge pull request #5875 from Ji-Xinyou/xyji/refactor-shim-mgmt
...
refactor(shim-mgmt): move client side to libs
2022-12-15 10:59:45 +08:00
Alex
b5cfd09583
kata-ctl: Fixed format for check release options
...
Fixed formatting for check release options
Fixes : #5345
Signed-off-by: Alex <alee23@bu.edu >
Signed-off-by: David Esparza <david.esparza.borquez@intel.com >
2022-12-14 09:42:57 -06:00
Georgina Kinge
0701e171e2
agent: removing sysinfo during merge
...
Removed the sysinfo that got left behind during merge
Signed-off-by: Georgina Kinge <georgina.kinge@ibm.com >
2022-12-14 15:36:13 +00:00
Georgina Kinge
332a425145
CCv0: Merge main into CCv0 branch
...
Merge remote-tracking branch 'upstream/main' into CCv0
Fixes : #5905
Signed-off-by: Georgina Kinge <georgina.kinge@ibm.com >
2022-12-14 14:55:23 +00:00
James O. D. Hunt
2e15af777c
Merge pull request #5786 from alexlee-23/main
...
kata-ctl: check: only-list-releases and include-all-releases options
2022-12-14 11:25:36 +00:00
Ji-Xinyou
fbf294da3f
refactor(shim-mgmt): move client side to libs
...
The client side is moved to libs. This is to solve the problem
that including clients will bring about messy dependencies.
Fixes : #5874
Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com >
2022-12-14 17:42:25 +08:00
Peng Tao
856d4b7361
Merge pull request #5798 from pmores/qemu-support
...
basic framework for QEMU support in runtime-rs
2022-12-14 15:05:33 +08:00
Binbin Zhang
99485d871c
shim: return hypervisor's pid not shim's pid
...
update outdated code comments
Fixes : #3234
Signed-off-by: Binbin Zhang <binbin36520@gmail.com >
2022-12-14 11:16:11 +08:00
Chao Wu
bb4be2a666
Merge pull request #5690 from yipengyin/fix-virtiofsd
...
runtime-rs: fix standalone share fs
2022-12-14 00:16:10 +08:00
Pavel Mores
1f28ff6838
runtime-rs: add binary to exercise shim proper w/o containerd dependencies
...
After building the binary as usual with `cargo build` run it as follows.
It needs a configuration.toml in which only qemu keys `path`, `kernel`
and `initrd` will initially need to be set. Point them to respective
files e.g. from a kata distribution tarball.
It also needs to be launched from an exported container bundle
directory. One can be created by running
mkdir rootfs
podman export $(podman create busybox) | tar -C ./rootfs -xvf -
runc spec -b .
in a suitable directory.
Then launch the program like this:
KATA_CONF_FILE=/path/to/configuration-qemu.toml /path/to/shim-ctl
Fixes : #5817
Signed-off-by: Pavel Mores <pmores@redhat.com >
2022-12-13 14:55:21 +01:00
Pavel Mores
eb8c9d38ff
runtime-rs: add launch of a simple qemu process to start_vm()
...
The point here is just to get a simplest Kata VM running.
Signed-off-by: Pavel Mores <pmores@redhat.com >
2022-12-13 14:54:26 +01:00
Pavel Mores
2f6d0d408b
runtime-rs: support qemu in VirtContainer
...
Added registration of qemu config plugin and support for creating Qemu
Hypervisor instance.
Signed-off-by: Pavel Mores <pmores@redhat.com >
2022-12-13 14:54:26 +01:00
Pavel Mores
1413dfe91c
runtime-rs: add basic empty boilerplate for qemu driver
...
This does almost literally nothing so far apart from getting and setting
HypervisorConfig. It's mostly copied from/inspired by dragonball.
Signed-off-by: Pavel Mores <pmores@redhat.com >
2022-12-13 14:53:45 +01:00
Bin Liu
3952fedcd0
Merge pull request #5882 from bergwolf/github/oci-namespaces
...
runtime-rs: fix sandbox_pidns calculation and oci spec amending
2022-12-13 18:32:02 +08:00
Fabiano Fidêncio
f1381eb361
Merge pull request #4813 from ManaSugi/fix/add-selinux-agent
...
runtime,agent: Add SELinux support for containers inside the guest
2022-12-13 11:24:53 +01:00
Fupan Li
015674df16
Merge pull request #5873 from justxuewei/fix/umount2
...
kata-sys-util: fix issues where umount2 couldn't get the correct path
2022-12-13 15:52:32 +08:00
Bin Liu
03b6124fc6
Merge pull request #5848 from Yuan-Zhuo/drop-cgmr-option
...
agent: Drop the Option for LinuxContainer.cgroup_manager
2022-12-13 12:09:39 +08:00
Alex
8dbfc3dc82
kata-ctl: Fixed format for check release options
...
Fixed formatting for check release options
Fixes : #5345
Signed-off-by: Alex <alee23@bu.edu >
2022-12-13 03:10:19 +00:00
Alex
f3091a9da4
kata-ctl: Add kata-ctl check release options
...
This pull request adds kata-ctl check only-list-releases and include-all-releases
Fixes : #5345
Signed-off-by: Alex <alee23@bu.edu >
2022-12-13 03:04:30 +00:00
Fabiano Fidêncio
788f1e6d61
config: Adjust TDXKERNELPARAMS for different VMMs
...
As Cloud Hypervisor and QEMU are using different rootfs images (the
former with `offline_fs_kbc` as aa_kbc, and the latter with `eaa_kbc`),
we need to differentiate the kernel parameters passed to each one of
those, as the `root_hash.txt` file used for measured boot will differ
according to the rootfs used.
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2022-12-12 13:54:56 +01:00
Fabiano Fidêncio
24c7066425
config: Drop $(ROOTMEASURECONFIG) from SEV kernel param
...
This is not used at all, as SEV relies on an initrd instead of relying
on an image.
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2022-12-12 13:54:56 +01:00
Fabiano Fidêncio
0a1de98179
build_image: config: Allow passing a specific root_hash_suffix
...
By doing this we can ensure that when building different rootfs-images
we won't end up overring the `root_hash.txt` file.
Plus, this will help us later in this series to pass the correct
argument to be used with the respective image.
Nothing's been done for SEV as it uses a initrd instead of an image.
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2022-12-12 13:54:52 +01:00