Fabiano Fidêncio
4fb163d570
runtime-rs: Allow clippy:box_default warnings
...
As the rust toolchain version bump to its 1.66.0 release raised a
warning about using Box::default() instead of specifying a type.
For now that's something we don't need to change, so let's ignore such
warning in this very specific case.
See:
https://rust-lang.github.io/rust-clippy/master/index.html#box_default
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 17:14:01 +01:00
Fabiano Fidêncio
20121fcda7
runtime-rs: Fix unnecessary_cast warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to unnecessary_cast.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 16:16:39 +01:00
Fabiano Fidêncio
b95364a140
dragonball: Allow question_mark warning in allocate_device_resources()
...
As the rust toolchain version bump to its 1.66.0 release raised a
warning about the code being able to be refactored to use `?`.
For now that's something we don't need to change, so let's ignore such
warning in this very specific case.
See:
https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:55:49 +01:00
Fabiano Fidêncio
0b2f060bf3
dragonball: Fix unnecessary_cast warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to unnecessary_cast.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:55:42 +01:00
Fabiano Fidêncio
a545a65934
agent: Allow clippy::question_mark warning in Namespace{}
...
As the rust toolchain version bump to its 1.66.0 release raised a
warning about the code being able to be refactored to use `?`.
For now that's something we don't need to change, so let's ignore such
warning in this very specific case.
See:
https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 15:22:20 +01:00
Fabiano Fidêncio
9ced34dd22
agent: Fix explicit_auto_deref warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to explicit_auto_deref.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:59:50 +01:00
Fabiano Fidêncio
f77220490e
agent: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:58:13 +01:00
Fabiano Fidêncio
7bcdc9049a
rustjail: Fix unnecessary_cast warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to unnecessary_cast.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:42:58 +01:00
Fabiano Fidêncio
41d7dbaaea
rustjail: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:42:25 +01:00
Fabiano Fidêncio
2a73e057db
kata-types: Fix unnecessary_cast warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to unnecessary_cast.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:28:07 +01:00
Fabiano Fidêncio
cf9ef1833c
kata-types: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:28:07 +01:00
Fabiano Fidêncio
126187e814
safe-path: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:28:07 +01:00
Fabiano Fidêncio
bb78d35db8
kata-sys-util: Fix "match-like-matches-macro" warning
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to "match-like-matches-macro".
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:28:07 +01:00
Fabiano Fidêncio
668e652401
kata-sys-util: Fix unnecessary_cast warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to unnecessary_cast.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:28:07 +01:00
Fabiano Fidêncio
c1a8d89a72
kata-sys-util: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:28:07 +01:00
Fabiano Fidêncio
c9c38e6d01
logging: Allow clippy::type-complexity warning
...
As the rust toolchain version bump to its 1.66.0 release raised a
warning about the type complexity used for the closure, and that's
something we don't want to change, let's ignore such warning in this
very specific case.
See:
https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:28:07 +01:00
Fabiano Fidêncio
ffd6fbb6b6
logging: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:18:14 +01:00
Fabiano Fidêncio
60df30015b
protocols: Fix unnecessary_cast warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to unnecessary_cast.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 14:18:14 +01:00
Fabiano Fidêncio
0bbeb34b4c
protocols: Fix needless_borrow warnings
...
As we bumped the rust toolchain to 1.66.0, some new warnings have been
raised due to needless_borrow.
Let's fix them all here.
For more info about the warnings, please, take a look at:
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com >
2023-01-02 12:41:29 +01:00
Chao Wu
1511587a9a
Merge pull request #5601 from openanolis/hugepage
...
runtime-rs: enable hugepage
2022-12-25 22:35:06 +08:00
Fupan Li
dc9c8d3357
Merge pull request #5901 from justxuewei/fix/mpleak
...
runtime-rs: Clean up mount points shared to guest
2022-12-21 09:59:25 +08:00
Jianyong Wu
3480780bd8
kata-ctl: add check framework support for non-x86
...
x86 changes the check framwork. Enable them for non-x86 accordingly.
Fixes : #5923
Signed-off-by: Jianyong Wu <jianyong.wu@arm.com >
2022-12-20 11:41:00 +08:00
Jianyong Wu
1bd533f10b
kata-ctl: let check framework arch-agnostic
...
The current check framwork is specific for x86. Refactor the code
to let it arch-agnostic.
Fixes : #5923
Signed-off-by: Jianyong Wu <jianyong.wu@arm.com >
2022-12-20 11:41:00 +08:00
Bin Liu
0cf443a612
Merge pull request #5915 from openanolis/legacy_device
...
dragonball: refactor legacy device initialization
2022-12-19 13:31:45 +08:00
Xuewei Niu
fd77eebd4d
runtime-rs: fix the issues mentioned in the code review
...
In order to avoid cloning, changed the signature of
`ShareFsMount::share_rootfs`, `ShareFsMount::share_volume`, and
`ShareFsMount::umount_rootfs` to receive a reference to a config.
Fixes : #5898
Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com >
2022-12-19 11:46:50 +08:00
Xuewei Niu
0e69207909
runtime-rs: Clean up mount points shared to guest
...
Fixed issues where shared volumes couldn't umount correctly.
The rootfs of each container is cleaned up after the container is killed, except
for `NydusRootfs`. `ShareFsRootfs::cleanup()` calls
`VirtiofsShareMount::umount_rootfs()` to umount mount points shared to the
guest, and umounts the bundle rootfs.
Fixes : #5898
Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com >
2022-12-19 11:46:14 +08:00
Bin Liu
e4645642d0
Merge pull request #5877 from openanolis/fix_start_bundle
...
runtime-rs: enable start container from bundle
2022-12-17 08:10:08 +08:00
Yushuo
d14c3af35c
dragonball: refactor legacy device initialization
...
If the serial path is given, legacy_manager should create socket console
based on that path. Or the console should be created based on stdio.
Fixes : #5914
Signed-off-by: Yushuo <y-shuo@linux.alibaba.com >
2022-12-15 20:55:01 +08:00
Zhongtao Hu
ca39a07a14
runtime-rs: enable start container from bundle
...
enable start container from bundle in this way
$ ls ./bundle
config.json rootfs
$ sudo ctr run -d --runtime io.containerd.kata.v2 --config bundle/config.json test_kata
Fixes:#5872
Signed-off-by: Zhongtao Hu <zhongtaohu.tim@linux.alibaba.com >
2022-12-15 17:28:13 +08:00
Peng Tao
ebb73df6bc
Merge pull request #5899 from Bevisy/fix-outdated-comments
...
shim: return hypervisor's pid not shim's pid
2022-12-15 14:55:54 +08:00
Chao Wu
fad229b853
Merge pull request #5875 from Ji-Xinyou/xyji/refactor-shim-mgmt
...
refactor(shim-mgmt): move client side to libs
2022-12-15 10:59:45 +08:00
Alex
b5cfd09583
kata-ctl: Fixed format for check release options
...
Fixed formatting for check release options
Fixes : #5345
Signed-off-by: Alex <alee23@bu.edu >
Signed-off-by: David Esparza <david.esparza.borquez@intel.com >
2022-12-14 09:42:57 -06:00
James O. D. Hunt
2e15af777c
Merge pull request #5786 from alexlee-23/main
...
kata-ctl: check: only-list-releases and include-all-releases options
2022-12-14 11:25:36 +00:00
Ji-Xinyou
fbf294da3f
refactor(shim-mgmt): move client side to libs
...
The client side is moved to libs. This is to solve the problem
that including clients will bring about messy dependencies.
Fixes : #5874
Signed-off-by: Ji-Xinyou <jerryji0414@outlook.com >
2022-12-14 17:42:25 +08:00
Peng Tao
856d4b7361
Merge pull request #5798 from pmores/qemu-support
...
basic framework for QEMU support in runtime-rs
2022-12-14 15:05:33 +08:00
Binbin Zhang
99485d871c
shim: return hypervisor's pid not shim's pid
...
update outdated code comments
Fixes : #3234
Signed-off-by: Binbin Zhang <binbin36520@gmail.com >
2022-12-14 11:16:11 +08:00
Chao Wu
bb4be2a666
Merge pull request #5690 from yipengyin/fix-virtiofsd
...
runtime-rs: fix standalone share fs
2022-12-14 00:16:10 +08:00
Pavel Mores
1f28ff6838
runtime-rs: add binary to exercise shim proper w/o containerd dependencies
...
After building the binary as usual with `cargo build` run it as follows.
It needs a configuration.toml in which only qemu keys `path`, `kernel`
and `initrd` will initially need to be set. Point them to respective
files e.g. from a kata distribution tarball.
It also needs to be launched from an exported container bundle
directory. One can be created by running
mkdir rootfs
podman export $(podman create busybox) | tar -C ./rootfs -xvf -
runc spec -b .
in a suitable directory.
Then launch the program like this:
KATA_CONF_FILE=/path/to/configuration-qemu.toml /path/to/shim-ctl
Fixes : #5817
Signed-off-by: Pavel Mores <pmores@redhat.com >
2022-12-13 14:55:21 +01:00
Pavel Mores
eb8c9d38ff
runtime-rs: add launch of a simple qemu process to start_vm()
...
The point here is just to get a simplest Kata VM running.
Signed-off-by: Pavel Mores <pmores@redhat.com >
2022-12-13 14:54:26 +01:00
Pavel Mores
2f6d0d408b
runtime-rs: support qemu in VirtContainer
...
Added registration of qemu config plugin and support for creating Qemu
Hypervisor instance.
Signed-off-by: Pavel Mores <pmores@redhat.com >
2022-12-13 14:54:26 +01:00
Pavel Mores
1413dfe91c
runtime-rs: add basic empty boilerplate for qemu driver
...
This does almost literally nothing so far apart from getting and setting
HypervisorConfig. It's mostly copied from/inspired by dragonball.
Signed-off-by: Pavel Mores <pmores@redhat.com >
2022-12-13 14:53:45 +01:00
Bin Liu
3952fedcd0
Merge pull request #5882 from bergwolf/github/oci-namespaces
...
runtime-rs: fix sandbox_pidns calculation and oci spec amending
2022-12-13 18:32:02 +08:00
Fabiano Fidêncio
f1381eb361
Merge pull request #4813 from ManaSugi/fix/add-selinux-agent
...
runtime,agent: Add SELinux support for containers inside the guest
2022-12-13 11:24:53 +01:00
Fupan Li
015674df16
Merge pull request #5873 from justxuewei/fix/umount2
...
kata-sys-util: fix issues where umount2 couldn't get the correct path
2022-12-13 15:52:32 +08:00
Bin Liu
03b6124fc6
Merge pull request #5848 from Yuan-Zhuo/drop-cgmr-option
...
agent: Drop the Option for LinuxContainer.cgroup_manager
2022-12-13 12:09:39 +08:00
Alex
8dbfc3dc82
kata-ctl: Fixed format for check release options
...
Fixed formatting for check release options
Fixes : #5345
Signed-off-by: Alex <alee23@bu.edu >
2022-12-13 03:10:19 +00:00
Alex
f3091a9da4
kata-ctl: Add kata-ctl check release options
...
This pull request adds kata-ctl check only-list-releases and include-all-releases
Fixes : #5345
Signed-off-by: Alex <alee23@bu.edu >
2022-12-13 03:04:30 +00:00
Peng Tao
79cf38e6ea
runtime-rs: clear OCI spec namespace path
...
None of the host namespace paths make sense in the guest. Let's clear
them all before sending the spec to the agent.
Signed-off-by: Peng Tao <bergwolf@hyper.sh >
2022-12-12 11:07:14 +00:00
Peng Tao
62f4603e81
runtime-rs: reset rdma cgroup
...
We don't support rdma cgroups yet. Let's make sure it is reset to empty.
Signed-off-by: Peng Tao <bergwolf@hyper.sh >
2022-12-12 09:57:24 +00:00
Peng Tao
5b6596f54e
runtime-rs: CreateContainerRequest has Default
...
We can just use it to initialize the default fields.
Signed-off-by: Peng Tao <bergwolf@hyper.sh >
2022-12-12 09:57:24 +00:00