From f570a2cd409220e4433dc91ccbebacc1d66bb5a5 Mon Sep 17 00:00:00 2001 From: Archana Shinde Date: Thu, 25 Jun 2020 16:46:06 -0700 Subject: [PATCH] shimv2 : Remove workaround for sharedPidNs Removing code that existed as a workaround for a bug in how shared process namespaces were handled in the agent. That has been long fixed in the agent. With this, sharedPidNs will now work with shimv2. Fixes #337 Signed-off-by: Archana Shinde --- src/runtime/containerd-shim-v2/create.go | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/runtime/containerd-shim-v2/create.go b/src/runtime/containerd-shim-v2/create.go index e981039f9..8ef1f3996 100644 --- a/src/runtime/containerd-shim-v2/create.go +++ b/src/runtime/containerd-shim-v2/create.go @@ -132,14 +132,6 @@ func loadSpec(r *taskAPI.CreateTaskRequest) (*specs.Spec, string, error) { return nil, "", err } - // Todo: - // Since there is a bug in kata for sharedPidNs, here to - // remove the pidns to disable the sharePidNs temporarily, - // once kata fixed this issue, we can remove this line. - // For the bug, please see: - // https://github.com/kata-containers/kata-containers/src/runtime/issues/930 - removeNamespace(&ociSpec, specs.PIDNamespace) - return &ociSpec, bundlePath, nil }