From cc8f0a24e493c84e68c87d45d37a35b02c39b2c1 Mon Sep 17 00:00:00 2001 From: Gabriela Cervantes Date: Wed, 28 Jun 2023 16:39:10 +0000 Subject: [PATCH] metrics: Add checkmetrics to gha-run.sh for metrics CI This PR adds checkmetrics installation for gha-run.sh in order to compare results limits as part of the metrics CI. Fixes #7198 Signed-off-by: Gabriela Cervantes --- tests/metrics/gha-run.sh | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/tests/metrics/gha-run.sh b/tests/metrics/gha-run.sh index 867161673..d7108eaf7 100755 --- a/tests/metrics/gha-run.sh +++ b/tests/metrics/gha-run.sh @@ -13,6 +13,10 @@ kata_tarball_dir=${2:-kata-artifacts} metrics_dir="$(dirname "$(readlink -f "$0")")" source "${metrics_dir}/../common.bash" +declare -r results_dir="${metrics_dir}/results" +declare -r checkmetrics_dir="${metrics_dir}/cmd/checkmetrics" +declare -r checkmetrics_config_dir="${checkmetrics_dir}/ci_worker" + function create_symbolic_links() { local link_configuration_file="/opt/kata/share/defaults/kata-containers/configuration.toml" local source_configuration_file="/opt/kata/share/defaults/kata-containers/configuration-${KATA_HYPERVISOR}.toml" @@ -83,6 +87,22 @@ function check_containerd_config_for_kata() { fi } +function check_metrics() { + # Ensure we have the latest checkemtrics + pushd "${checkmetrics_dir}" + make + sudo make install + popd + + local cm_base_file="${checkmetrics_config_dir}/checkmetrics-json-${hypervisor}-$(uname -n).toml" + checkmetrics --debug --percentage --basefile "${cm_base_file}" --metricsdir "${results_dir}" + cm_result=$? + if [ "${cm_result}" != 0 ]; then + info "run-metrics-ci: checkmetrics FAILED (${cm_result})" + exit "${cm_result}" + fi +} + function run_test_launchtimes() { info "Running Launch Time test using ${KATA_HYPERVISOR} hypervisor" @@ -119,6 +139,8 @@ function main() { run-test-memory-usage-inside-container) run_test_memory_usage_inside_container ;; *) >&2 die "Invalid argument" ;; esac + + check_metrics } main "$@"