diff --git a/src/agent/rustjail/src/cgroups/notifier.rs b/src/agent/rustjail/src/cgroups/notifier.rs index b429a234c..9f91b3584 100644 --- a/src/agent/rustjail/src/cgroups/notifier.rs +++ b/src/agent/rustjail/src/cgroups/notifier.rs @@ -151,12 +151,12 @@ async fn register_memory_event( let eventfd = eventfd(0, EfdFlags::EFD_CLOEXEC)?; let event_control_path = Path::new(&cg_dir).join("cgroup.event_control"); - let data; - if arg.is_empty() { - data = format!("{} {}", eventfd, event_file.as_raw_fd()); + + let data = if arg.is_empty() { + format!("{} {}", eventfd, event_file.as_raw_fd()) } else { - data = format!("{} {} {}", eventfd, event_file.as_raw_fd(), arg); - } + format!("{} {} {}", eventfd, event_file.as_raw_fd(), arg) + }; fs::write(&event_control_path, data)?; diff --git a/src/agent/rustjail/src/lib.rs b/src/agent/rustjail/src/lib.rs index 7535bf990..bceb9cd04 100644 --- a/src/agent/rustjail/src/lib.rs +++ b/src/agent/rustjail/src/lib.rs @@ -351,13 +351,12 @@ fn seccomp_grpc_to_oci(sec: &grpc::LinuxSeccomp) -> oci::LinuxSeccomp { for sys in sec.Syscalls.iter() { let mut args = Vec::new(); - let errno_ret: u32; - if sys.has_errnoret() { - errno_ret = sys.get_errnoret(); + let errno_ret: u32 = if sys.has_errnoret() { + sys.get_errnoret() } else { - errno_ret = libc::EPERM as u32; - } + libc::EPERM as u32 + }; for arg in sys.Args.iter() { args.push(oci::LinuxSeccompArg { diff --git a/src/agent/src/main.rs b/src/agent/src/main.rs index d62f1e64c..f75f885b5 100644 --- a/src/agent/src/main.rs +++ b/src/agent/src/main.rs @@ -125,9 +125,7 @@ fn announce(logger: &Logger, config: &AgentConfig) { // output to the vsock port specified, or stdout. async fn create_logger_task(rfd: RawFd, vsock_port: u32, shutdown: Receiver) -> Result<()> { let mut reader = PipeStream::from_fd(rfd); - let mut writer: Box; - - if vsock_port > 0 { + let mut writer: Box = if vsock_port > 0 { let listenfd = socket::socket( AddressFamily::Vsock, SockType::Stream, @@ -139,10 +137,10 @@ async fn create_logger_task(rfd: RawFd, vsock_port: u32, shutdown: Receiver>) -> Result } let mut p = process.unwrap(); - let ret: i32; - match wait_status { - WaitStatus::Exited(_, c) => ret = c, - WaitStatus::Signaled(_, sig, _) => ret = sig as i32, + let ret: i32 = match wait_status { + WaitStatus::Exited(_, c) => c, + WaitStatus::Signaled(_, sig, _) => sig as i32, _ => { info!(logger, "got wrong status for process"; "child-status" => format!("{:?}", wait_status)); continue; } - } + }; p.exit_code = ret; let _ = p.exit_tx.take(); diff --git a/src/agent/src/util.rs b/src/agent/src/util.rs index 488e6ca6b..c4645f975 100644 --- a/src/agent/src/util.rs +++ b/src/agent/src/util.rs @@ -237,8 +237,6 @@ mod tests { JoinError, >; - let result: std::result::Result; - select! { res = handle => spawn_result = res, _ = &mut timeout => panic!("timed out"), @@ -246,7 +244,7 @@ mod tests { assert!(spawn_result.is_ok()); - result = spawn_result.unwrap(); + let result: std::result::Result = spawn_result.unwrap(); assert!(result.is_ok()); @@ -278,8 +276,6 @@ mod tests { let spawn_result: std::result::Result, JoinError>; - let result: std::result::Result; - select! { res = handle => spawn_result = res, _ = &mut timeout => panic!("timed out"), @@ -287,7 +283,7 @@ mod tests { assert!(spawn_result.is_ok()); - result = spawn_result.unwrap(); + let result: std::result::Result = spawn_result.unwrap(); assert!(result.is_ok()); @@ -320,8 +316,6 @@ mod tests { let spawn_result: std::result::Result, JoinError>; - let result: std::result::Result; - select! { res = handle => spawn_result = res, _ = &mut timeout => panic!("timed out"), @@ -329,7 +323,7 @@ mod tests { assert!(spawn_result.is_ok()); - result = spawn_result.unwrap(); + let result: std::result::Result = spawn_result.unwrap(); assert!(result.is_ok()); diff --git a/src/agent/vsock-exporter/src/lib.rs b/src/agent/vsock-exporter/src/lib.rs index 27e71e64b..776c3b548 100644 --- a/src/agent/vsock-exporter/src/lib.rs +++ b/src/agent/vsock-exporter/src/lib.rs @@ -178,13 +178,11 @@ impl Builder { pub fn init(self) -> Exporter { let Builder { port, cid, logger } = self; - let cid_str: String; - - if self.cid == libc::VMADDR_CID_ANY { - cid_str = ANY_CID.to_string(); + let cid_str: String = if self.cid == libc::VMADDR_CID_ANY { + ANY_CID.to_string() } else { - cid_str = format!("{}", self.cid); - } + format!("{}", self.cid) + }; Exporter { port,