From 13715db1f831ae467f987ef543e87455caf05f53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Thu, 13 Jul 2023 22:05:54 +0200 Subject: [PATCH] tests: Do not call `install_check_metrics` when installing kata MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `install_kata` function was moved from the metrics' `gha-run.sh` file to the `common.bash` in the commit 3ffd48bc16, but I didn't notice that it brought with it a call to `install_check_metrics`, which is totally unrelated to installing Kata Containers. Let's remove the call so the function is a little bit less specific, and move the call to install_check_metrics to the metrics `gha-run.sh` file. Signed-off-by: Fabiano Fidêncio --- tests/common.bash | 1 - tests/metrics/gha-run.sh | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/common.bash b/tests/common.bash index 75598b24e..576370336 100644 --- a/tests/common.bash +++ b/tests/common.bash @@ -318,7 +318,6 @@ function install_kata() { check_containerd_config_for_kata restart_containerd_service - install_checkmetrics } function check_containerd_config_for_kata() { diff --git a/tests/metrics/gha-run.sh b/tests/metrics/gha-run.sh index 6bc472e7a..a89342b9b 100755 --- a/tests/metrics/gha-run.sh +++ b/tests/metrics/gha-run.sh @@ -95,7 +95,7 @@ function run_test_tensorflow() { function main() { action="${1:-}" case "${action}" in - install-kata) install_kata ;; + install-kata) install_kata && install_checkmetrics ;; make-tarball-results) make_tarball_results ;; run-test-launchtimes) run_test_launchtimes ;; run-test-memory-usage) run_test_memory_usage ;;