From 0926c8d9b4e4f78994a2accae7c2bd4b2a450b22 Mon Sep 17 00:00:00 2001
From: lifupan <lifupan@gmail.com>
Date: Wed, 21 Aug 2019 20:19:42 +0800
Subject: [PATCH] virtcontainers: Fix the issue of watching console for
 firecracker

Since firecracker hasn't support console watching by now, so skip
watching console if the consoleURL is empty.

Fixes: #1970

Signed-off-by: lifupan <lifupan@gmail.com>
---
 virtcontainers/proxy.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/virtcontainers/proxy.go b/virtcontainers/proxy.go
index 5fb512635..b8cbfbf09 100644
--- a/virtcontainers/proxy.go
+++ b/virtcontainers/proxy.go
@@ -239,7 +239,9 @@ func (p *proxyBuiltin) start(params proxyParams) (int, string, error) {
 
 	p.sandboxID = params.id
 
-	if params.debug {
+	// For firecracker, it hasn't support the console watching and it's consoleURL
+	// will be set empty.
+	if params.debug && params.consoleURL != "" {
 		err := p.watchConsole(buildinProxyConsoleProto, params.consoleURL, params.logger)
 		if err != nil {
 			p.sandboxID = ""