From fdcf3744629de6bdbd74dc5d6a6bc34dda1a6be2 Mon Sep 17 00:00:00 2001 From: Salman Mohammed Date: Tue, 11 Feb 2025 09:52:45 -0500 Subject: [PATCH] fix: write to config yaml if provider test succeeds (#1178) --- crates/goose-cli/src/commands/configure.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/crates/goose-cli/src/commands/configure.rs b/crates/goose-cli/src/commands/configure.rs index a998a50e..678390cc 100644 --- a/crates/goose-cli/src/commands/configure.rs +++ b/crates/goose-cli/src/commands/configure.rs @@ -283,10 +283,6 @@ pub async fn configure_provider_dialog() -> Result> { .default_input(&default_model) .interact()?; - // Update config with new values - config.set("GOOSE_PROVIDER", Value::String(provider_name.to_string()))?; - config.set("GOOSE_MODEL", Value::String(model.clone()))?; - // Test the configuration let spin = spinner(); spin.start("Checking your configuration..."); @@ -319,6 +315,9 @@ pub async fn configure_provider_dialog() -> Result> { match result { Ok((_message, _usage)) => { + // Update config with new values only if the test succeeds + config.set("GOOSE_PROVIDER", Value::String(provider_name.to_string()))?; + config.set("GOOSE_MODEL", Value::String(model.clone()))?; cliclack::outro("Configuration saved successfully")?; Ok(true) }