aljaz/goose
1
0
Fork 0
mirror of https://github.com/aljazceru/goose.git synced 2025-12-18 14:44:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: remove permission when deleting extension (#2089)

Browse Source
This commit is contained in:
Yingjie He
2025-04-08 13:25:48 -07:00
committed by GitHub
parent 4f9f21ac90
commit f812ca12ff
2 changed files with 46 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/goose-cli/src/commands/configure.rs
View File

@@ -2,7 +2,9 @@ use cliclack::spinner;
use console::style;
use goose::agents::{extension::Envs, ExtensionConfig};
use goose::config::extensions::name_to_key;
use goose::config::{Config, ConfigError, ExperimentManager, ExtensionEntry, ExtensionManager};
use goose::config::{
Config, ConfigError, ExperimentManager, ExtensionEntry, ExtensionManager, PermissionManager,
};
use goose::message::Message;
use goose::providers::{create, providers};
use mcp_core::tool::ToolAnnotations;
@@ -738,6 +740,8 @@ pub fn remove_extension_dialog() -> Result<(), Box<dyn Error>> {
for name in selected {
ExtensionManager::remove(&name_to_key(name))?;
let mut permission_manager = PermissionManager::default();
permission_manager.remove_extension(&name_to_key(name));
cliclack::outro(format!("Removed {} extension", style(name).green()))?;
}

41
crates/goose/src/config/permission.rs
View File

@@ -179,6 +179,25 @@ impl PermissionManager {
.expect("Failed to serialize permission config");
fs::write(&self.config_path, yaml_content).expect("Failed to write to permission.yaml");
}
/// Removes all entries where the principal name starts with the given extension name.
pub fn remove_extension(&mut self, extension_name: &str) {
for permission_config in self.permission_map.values_mut() {
permission_config
.always_allow
.retain(|p| !p.starts_with(extension_name));
permission_config
.ask_before
.retain(|p| !p.starts_with(extension_name));
permission_config
.never_allow
.retain(|p| !p.starts_with(extension_name));
}
let yaml_content = serde_yaml::to_string(&self.permission_map)
.expect("Failed to serialize permission config");
fs::write(&self.config_path, yaml_content).expect("Failed to write to permission.yaml");
}
}
#[cfg(test)]
@@ -273,4 +292,26 @@ mod tests {
assert!(!config.ask_before.contains(&"tool7".to_string()));
assert!(config.never_allow.contains(&"tool7".to_string()));
}
#[test]
fn test_remove_extension() {
let mut manager = create_test_permission_manager();
manager.update_user_permission("prefix__tool1", PermissionLevel::AlwaysAllow);
manager.update_user_permission("nonprefix__tool2", PermissionLevel::AlwaysAllow);
manager.update_user_permission("prefix__tool3", PermissionLevel::AskBefore);
// Remove entries starting with "prefix"
manager.remove_extension("prefix");
let config = manager.permission_map.get(USER_PERMISSION).unwrap();
// Verify entries with "prefix" are removed
assert!(!config.always_allow.contains(&"prefix__tool1".to_string()));
assert!(!config.ask_before.contains(&"prefix__tool3".to_string()));
// Verify other entries remain
assert!(config
.always_allow
.contains(&"nonprefix__tool2".to_string()));
}
}