From 63623733dcf41efb7d4ba0b4feda65b8702a71f1 Mon Sep 17 00:00:00 2001 From: Alex Hancock Date: Mon, 7 Apr 2025 16:20:25 -0400 Subject: [PATCH] feat: disallow env vars for extensions with spaces in the name (#2066) --- .../settings_v2/extensions/modal/EnvVarsSection.tsx | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/ui/desktop/src/components/settings_v2/extensions/modal/EnvVarsSection.tsx b/ui/desktop/src/components/settings_v2/extensions/modal/EnvVarsSection.tsx index 45380405..0dd56773 100644 --- a/ui/desktop/src/components/settings_v2/extensions/modal/EnvVarsSection.tsx +++ b/ui/desktop/src/components/settings_v2/extensions/modal/EnvVarsSection.tsx @@ -30,6 +30,7 @@ export default function EnvVarsSection({ const handleAdd = () => { const keyEmpty = !newKey.trim(); const valueEmpty = !newValue.trim(); + const keyHasSpaces = newKey.includes(' '); if (keyEmpty || valueEmpty) { setInvalidFields({ @@ -40,6 +41,15 @@ export default function EnvVarsSection({ return; } + if (keyHasSpaces) { + setInvalidFields({ + key: true, + value: false, + }); + setValidationError('Variable name cannot contain spaces'); + return; + } + setValidationError(null); setInvalidFields({ key: false, value: false }); onAdd(newKey, newValue);