From 59da8f2349002c06e9697381f760b09ef35bc094 Mon Sep 17 00:00:00 2001
From: Lily Delalande <119957291+lily-de@users.noreply.github.com>
Date: Mon, 31 Mar 2025 11:27:18 -0400
Subject: [PATCH] ui: no shim in config (#1916)

---
 ui/desktop/src/components/ConfigContext.tsx                  | 5 +++++
 .../settings_v2/extensions/modal/ExtensionModal.tsx          | 1 +
 2 files changed, 6 insertions(+)

diff --git a/ui/desktop/src/components/ConfigContext.tsx b/ui/desktop/src/components/ConfigContext.tsx
index 2d1c0581..6eaf2231 100644
--- a/ui/desktop/src/components/ConfigContext.tsx
+++ b/ui/desktop/src/components/ConfigContext.tsx
@@ -19,6 +19,7 @@ import type {
   ExtensionQuery,
   ExtensionConfig,
 } from '../api/types.gen';
+import { removeShims } from './settings_v2/extensions/utils';
 
 // Define a local version that matches the structure of the imported one
 export type FixedExtensionEntry = ExtensionConfig & {
@@ -118,6 +119,10 @@ export const ConfigProvider: React.FC<ConfigProviderProps> = ({ children }) => {
   };
 
   const addExtension = async (name: string, config: ExtensionConfig, enabled: boolean) => {
+    // remove shims if present
+    if (config.type == 'stdio') {
+      config.cmd = removeShims(config.cmd);
+    }
     const query: ExtensionQuery = { name, config, enabled };
     await apiAddExtension({
       body: query,
diff --git a/ui/desktop/src/components/settings_v2/extensions/modal/ExtensionModal.tsx b/ui/desktop/src/components/settings_v2/extensions/modal/ExtensionModal.tsx
index 2245df36..1715de5a 100644
--- a/ui/desktop/src/components/settings_v2/extensions/modal/ExtensionModal.tsx
+++ b/ui/desktop/src/components/settings_v2/extensions/modal/ExtensionModal.tsx
@@ -96,6 +96,7 @@ export default function ExtensionModal({
     if (isFormValid()) {
       onSubmit(formData);
     }
+    onClose();
   };
 
   // Create footer buttons based on current state