aljaz/goose
1
0
Fork 0
mirror of https://github.com/aljazceru/goose.git synced 2025-12-18 22:54:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Improves reliability of flaky log tests (#3029)

Browse Source
This commit is contained in:
Jarrod Sibbison
2025-06-23 13:57:30 +10:00
committed by GitHub
parent bf7e47a096
commit 09b06c51ae
1 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
crates/goose-cli/src/logging.rs
View File

@@ -180,9 +180,9 @@ fn setup_logging_internal(
mod tests { mod tests {
use super::*; use super::*;
use chrono::TimeZone; use chrono::TimeZone;
use rand;
use std::env; use std::env;
use tempfile::TempDir; use tempfile::TempDir;
use test_case::test_case;
fn setup_temp_home() -> TempDir { fn setup_temp_home() -> TempDir {
let temp_dir = TempDir::new().unwrap(); let temp_dir = TempDir::new().unwrap();
@@ -209,16 +209,24 @@ mod tests {
} }
#[tokio::test] #[tokio::test]
#[test_case(Some("test_session"), true ; "with session name and error capture")] async fn test_log_file_name_session_with_error_capture() {
#[test_case(Some("test_session"), false ; "with session name without error capture")] do_test_log_file_name(Some("test_session_with_error"), true).await;
#[test_case(None, false ; "without session name")] }
async fn test_log_file_name(session_name: Option<&str>, _with_error_capture: bool) {
#[tokio::test]
async fn test_log_file_name_session_without_error_capture() {
do_test_log_file_name(Some("test_session_without_error"), false).await;
}
#[tokio::test]
async fn test_log_file_name_no_session() {
do_test_log_file_name(None, false).await;
}
async fn do_test_log_file_name(session_name: Option<&str>, _with_error_capture: bool) {
// Create a unique test directory for each test // Create a unique test directory for each test
let test_name = session_name.unwrap_or("no_session"); let test_name = session_name.unwrap_or("no_session");
let random_suffix = std::time::SystemTime::now() let random_suffix = rand::random::<u32>() % 100000000;
.duration_since(std::time::UNIX_EPOCH)
.unwrap()
.subsec_nanos();
let test_dir = PathBuf::from(format!( let test_dir = PathBuf::from(format!(
"/tmp/goose_test_home_{}_{}", "/tmp/goose_test_home_{}_{}",
test_name, random_suffix test_name, random_suffix