From 0020123ee81cda212a15032c3d135e65e863a9af Mon Sep 17 00:00:00 2001 From: Salman Mohammed Date: Thu, 30 Jan 2025 20:24:53 -0500 Subject: [PATCH] fix: temp fix to make CI workflow pass (#970) --- .github/workflows/canary.yml | 4 ++-- .github/workflows/ci.yml | 1 + .github/workflows/pr-comment-bundle-desktop.yml | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/canary.yml b/.github/workflows/canary.yml index 35b92c4a..3356e4cf 100644 --- a/.github/workflows/canary.yml +++ b/.github/workflows/canary.yml @@ -28,9 +28,9 @@ jobs: - name: Generate a canary version id: set-version run: | - # Something like "1.0.0-canary." + # TODO: fix this to be dynamic - extract version from repo SHORT_SHA=$(echo "${GITHUB_SHA}" | cut -c1-7) - VERSION="1.0.0-canary.${SHORT_SHA}" + VERSION="1.0.3-canary.${SHORT_SHA}" echo "version=$VERSION" >> $GITHUB_OUTPUT # ------------------------------------ diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6ad02828..d7c9dcb8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -104,4 +104,5 @@ jobs: uses: ./.github/workflows/bundle-desktop.yml if: github.event_name == 'pull_request' with: + version: 1.0.3 # TODO: fix this to be dynamic signing: false diff --git a/.github/workflows/pr-comment-bundle-desktop.yml b/.github/workflows/pr-comment-bundle-desktop.yml index a2527f32..1140070b 100644 --- a/.github/workflows/pr-comment-bundle-desktop.yml +++ b/.github/workflows/pr-comment-bundle-desktop.yml @@ -43,6 +43,7 @@ jobs: if: ${{ needs.trigger-on-command.outputs.continue == 'true' }} uses: ./.github/workflows/bundle-desktop.yml with: + version: 1.0.3 # TODO: fix this to be dynamic signing: true secrets: CERTIFICATE_OSX_APPLICATION: ${{ secrets.CERTIFICATE_OSX_APPLICATION }}