mirror of
https://github.com/lollipopkit/flutter_server_box.git
synced 2025-12-17 15:24:35 +01:00
3a615449e3
* feat: win compatibility * fix * fix: uptime parse * opt.: linux uptime accuracy * fix: windows temperature fetching * opt. * opt.: powershell exec * refactor: address PR review feedback and improve code quality ### Major Improvements: - **Refactored Windows status parsing**: Broke down large `_getWindowsStatus` method into 13 smaller, focused helper methods for better maintainability and readability - **Extracted system detection logic**: Created dedicated `SystemDetector` helper class to separate OS detection concerns from ServerProvider - **Improved concurrency handling**: Implemented proper synchronization for server updates using Future-based locks to prevent race conditions ### Bug Fixes: - **Fixed CPU percentage parsing**: Removed incorrect '*100' multiplication in BSD CPU parsing (values were already percentages) - **Enhanced memory parsing**: Added validation and error handling to BSD memory fallback parsing with proper logging - **Improved uptime parsing**: Added support for multiple Windows date formats and robust error handling with validation - **Fixed division by zero**: Added safety checks in Swap.usedPercent getter ### Code Quality Enhancements: - **Added comprehensive documentation**: Documented Windows CPU counter limitations and approach - **Strengthened error handling**: Added detailed logging and validation throughout parsing methods - **Improved robustness**: Enhanced BSD CPU parsing with percentage validation and warnings - **Better separation of concerns**: Each parsing method now has single responsibility ### Files Changed: - `lib/data/helper/system_detector.dart` (new): System detection helper - `lib/data/model/server/cpu.dart`: Fixed percentage parsing and added validation - `lib/data/model/server/memory.dart`: Enhanced fallback parsing and division-by-zero protection - `lib/data/model/server/server_status_update_req.dart`: Refactored into 13 focused parsing methods - `lib/data/provider/server.dart`: Improved synchronization and extracted system detection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: parse & shell fn struct --------- Co-authored-by: Claude <noreply@anthropic.com>
59 lines
1.8 KiB
Dart
59 lines
1.8 KiB
Dart
import 'package:fl_lib/fl_lib.dart';
|
|
import 'package:server_box/core/extension/context/locale.dart';
|
|
import 'package:server_box/data/model/server/server.dart';
|
|
|
|
enum NetViewType {
|
|
conn,
|
|
speed,
|
|
traffic;
|
|
|
|
NetViewType get next => switch (this) {
|
|
conn => speed,
|
|
speed => traffic,
|
|
traffic => conn,
|
|
};
|
|
|
|
String get toStr => switch (this) {
|
|
NetViewType.conn => l10n.conn,
|
|
NetViewType.traffic => l10n.traffic,
|
|
NetViewType.speed => l10n.speed,
|
|
};
|
|
|
|
/// If no device is specified, return the cached value (only real devices,
|
|
/// such as ethX, wlanX...).
|
|
(String, String) build(ServerStatus ss, {String? dev}) {
|
|
final notSepcifyDev = dev == null || dev.isEmpty;
|
|
try {
|
|
switch (this) {
|
|
case NetViewType.conn:
|
|
return ('${l10n.conn}:\n${ss.tcp.maxConn}', '${libL10n.fail}:\n${ss.tcp.fail}');
|
|
case NetViewType.speed:
|
|
if (notSepcifyDev) {
|
|
return ('↓:\n${ss.netSpeed.cachedVals.speedIn}', '↑:\n${ss.netSpeed.cachedVals.speedOut}');
|
|
}
|
|
return ('↓:\n${ss.netSpeed.speedIn(device: dev)}', '↑:\n${ss.netSpeed.speedOut(device: dev)}');
|
|
case NetViewType.traffic:
|
|
if (notSepcifyDev) {
|
|
return ('↓:\n${ss.netSpeed.cachedVals.sizeIn}', '↑:\n${ss.netSpeed.cachedVals.sizeOut}');
|
|
}
|
|
return ('↓:\n${ss.netSpeed.sizeIn(device: dev)}', '↑:\n${ss.netSpeed.sizeOut(device: dev)}');
|
|
}
|
|
} catch (e, s) {
|
|
Loggers.app.warning('NetViewType.build', e, s);
|
|
return ('N/A', 'N/A');
|
|
}
|
|
}
|
|
|
|
int toJson() => switch (this) {
|
|
NetViewType.conn => 0,
|
|
NetViewType.speed => 1,
|
|
NetViewType.traffic => 2,
|
|
};
|
|
|
|
static NetViewType fromJson(int json) => switch (json) {
|
|
0 => NetViewType.conn,
|
|
1 => NetViewType.speed,
|
|
_ => NetViewType.traffic,
|
|
};
|
|
}
|