mirror of
https://github.com/lollipopkit/flutter_server_box.git
synced 2025-12-17 23:34:24 +01:00
* feat: win compatibility * fix * fix: uptime parse * opt.: linux uptime accuracy * fix: windows temperature fetching * opt. * opt.: powershell exec * refactor: address PR review feedback and improve code quality ### Major Improvements: - **Refactored Windows status parsing**: Broke down large `_getWindowsStatus` method into 13 smaller, focused helper methods for better maintainability and readability - **Extracted system detection logic**: Created dedicated `SystemDetector` helper class to separate OS detection concerns from ServerProvider - **Improved concurrency handling**: Implemented proper synchronization for server updates using Future-based locks to prevent race conditions ### Bug Fixes: - **Fixed CPU percentage parsing**: Removed incorrect '*100' multiplication in BSD CPU parsing (values were already percentages) - **Enhanced memory parsing**: Added validation and error handling to BSD memory fallback parsing with proper logging - **Improved uptime parsing**: Added support for multiple Windows date formats and robust error handling with validation - **Fixed division by zero**: Added safety checks in Swap.usedPercent getter ### Code Quality Enhancements: - **Added comprehensive documentation**: Documented Windows CPU counter limitations and approach - **Strengthened error handling**: Added detailed logging and validation throughout parsing methods - **Improved robustness**: Enhanced BSD CPU parsing with percentage validation and warnings - **Better separation of concerns**: Each parsing method now has single responsibility ### Files Changed: - `lib/data/helper/system_detector.dart` (new): System detection helper - `lib/data/model/server/cpu.dart`: Fixed percentage parsing and added validation - `lib/data/model/server/memory.dart`: Enhanced fallback parsing and division-by-zero protection - `lib/data/model/server/server_status_update_req.dart`: Refactored into 13 focused parsing methods - `lib/data/provider/server.dart`: Improved synchronization and extracted system detection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: parse & shell fn struct --------- Co-authored-by: Claude <noreply@anthropic.com>
25 lines
775 B
Dart
25 lines
775 B
Dart
import 'package:dartssh2/dartssh2.dart';
|
|
import 'package:server_box/view/widget/unix_perm.dart';
|
|
|
|
extension SftpFileX on SftpFileMode {
|
|
String get str {
|
|
final user = _getRoleMode(userRead, userWrite, userExecute);
|
|
final group = _getRoleMode(groupRead, groupWrite, groupExecute);
|
|
final other = _getRoleMode(otherRead, otherWrite, otherExecute);
|
|
|
|
return '$user$group$other';
|
|
}
|
|
|
|
UnixPerm toUnixPerm() {
|
|
return UnixPerm(
|
|
user: UnixPermOp(r: userRead, w: userWrite, x: userExecute),
|
|
group: UnixPermOp(r: groupRead, w: groupWrite, x: groupExecute),
|
|
other: UnixPermOp(r: otherRead, w: otherWrite, x: otherExecute),
|
|
);
|
|
}
|
|
}
|
|
|
|
String _getRoleMode(bool r, bool w, bool x) {
|
|
return '${r ? 'r' : '-'}${w ? 'w' : '-'}${x ? 'x' : '-'}';
|
|
}
|