mirror of
https://github.com/lollipopkit/flutter_server_box.git
synced 2025-12-17 15:24:35 +01:00
* feat: win compatibility * fix * fix: uptime parse * opt.: linux uptime accuracy * fix: windows temperature fetching * opt. * opt.: powershell exec * refactor: address PR review feedback and improve code quality ### Major Improvements: - **Refactored Windows status parsing**: Broke down large `_getWindowsStatus` method into 13 smaller, focused helper methods for better maintainability and readability - **Extracted system detection logic**: Created dedicated `SystemDetector` helper class to separate OS detection concerns from ServerProvider - **Improved concurrency handling**: Implemented proper synchronization for server updates using Future-based locks to prevent race conditions ### Bug Fixes: - **Fixed CPU percentage parsing**: Removed incorrect '*100' multiplication in BSD CPU parsing (values were already percentages) - **Enhanced memory parsing**: Added validation and error handling to BSD memory fallback parsing with proper logging - **Improved uptime parsing**: Added support for multiple Windows date formats and robust error handling with validation - **Fixed division by zero**: Added safety checks in Swap.usedPercent getter ### Code Quality Enhancements: - **Added comprehensive documentation**: Documented Windows CPU counter limitations and approach - **Strengthened error handling**: Added detailed logging and validation throughout parsing methods - **Improved robustness**: Enhanced BSD CPU parsing with percentage validation and warnings - **Better separation of concerns**: Each parsing method now has single responsibility ### Files Changed: - `lib/data/helper/system_detector.dart` (new): System detection helper - `lib/data/model/server/cpu.dart`: Fixed percentage parsing and added validation - `lib/data/model/server/memory.dart`: Enhanced fallback parsing and division-by-zero protection - `lib/data/model/server/server_status_update_req.dart`: Refactored into 13 focused parsing methods - `lib/data/provider/server.dart`: Improved synchronization and extracted system detection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: parse & shell fn struct --------- Co-authored-by: Claude <noreply@anthropic.com>
26 lines
710 B
Dart
26 lines
710 B
Dart
import 'package:server_box/data/res/misc.dart';
|
|
|
|
class Conn {
|
|
final int maxConn;
|
|
final int active;
|
|
final int passive;
|
|
final int fail;
|
|
|
|
const Conn({required this.maxConn, required this.active, required this.passive, required this.fail});
|
|
|
|
static Conn? parse(String raw) {
|
|
final lines = raw.split('\n');
|
|
final idx = lines.lastWhere((element) => element.startsWith('Tcp:'), orElse: () => '');
|
|
if (idx != '') {
|
|
final vals = idx.split(Miscs.blankReg);
|
|
return Conn(
|
|
maxConn: int.tryParse(vals[5]) ?? 0,
|
|
active: int.tryParse(vals[6]) ?? 0,
|
|
passive: int.tryParse(vals[7]) ?? 0,
|
|
fail: int.tryParse(vals[8]) ?? 0,
|
|
);
|
|
}
|
|
return null;
|
|
}
|
|
}
|