mirror of
https://github.com/lollipopkit/flutter_server_box.git
synced 2025-12-17 15:24:35 +01:00
* feat: win compatibility * fix * fix: uptime parse * opt.: linux uptime accuracy * fix: windows temperature fetching * opt. * opt.: powershell exec * refactor: address PR review feedback and improve code quality ### Major Improvements: - **Refactored Windows status parsing**: Broke down large `_getWindowsStatus` method into 13 smaller, focused helper methods for better maintainability and readability - **Extracted system detection logic**: Created dedicated `SystemDetector` helper class to separate OS detection concerns from ServerProvider - **Improved concurrency handling**: Implemented proper synchronization for server updates using Future-based locks to prevent race conditions ### Bug Fixes: - **Fixed CPU percentage parsing**: Removed incorrect '*100' multiplication in BSD CPU parsing (values were already percentages) - **Enhanced memory parsing**: Added validation and error handling to BSD memory fallback parsing with proper logging - **Improved uptime parsing**: Added support for multiple Windows date formats and robust error handling with validation - **Fixed division by zero**: Added safety checks in Swap.usedPercent getter ### Code Quality Enhancements: - **Added comprehensive documentation**: Documented Windows CPU counter limitations and approach - **Strengthened error handling**: Added detailed logging and validation throughout parsing methods - **Improved robustness**: Enhanced BSD CPU parsing with percentage validation and warnings - **Better separation of concerns**: Each parsing method now has single responsibility ### Files Changed: - `lib/data/helper/system_detector.dart` (new): System detection helper - `lib/data/model/server/cpu.dart`: Fixed percentage parsing and added validation - `lib/data/model/server/memory.dart`: Enhanced fallback parsing and division-by-zero protection - `lib/data/model/server/server_status_update_req.dart`: Refactored into 13 focused parsing methods - `lib/data/provider/server.dart`: Improved synchronization and extracted system detection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: parse & shell fn struct --------- Co-authored-by: Claude <noreply@anthropic.com>
72 lines
1.9 KiB
Dart
72 lines
1.9 KiB
Dart
import 'package:fl_lib/fl_lib.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:server_box/core/extension/context/locale.dart';
|
|
import 'package:server_box/core/route.dart';
|
|
import 'package:server_box/view/page/ssh/page/page.dart';
|
|
|
|
class IPerfPage extends StatefulWidget {
|
|
final SpiRequiredArgs args;
|
|
|
|
const IPerfPage({super.key, required this.args});
|
|
|
|
@override
|
|
State<IPerfPage> createState() => _IPerfPageState();
|
|
|
|
static const route = AppRouteArg<void, SpiRequiredArgs>(page: IPerfPage.new, path: '/iperf');
|
|
}
|
|
|
|
class _IPerfPageState extends State<IPerfPage> {
|
|
final _hostCtrl = TextEditingController();
|
|
final _portCtrl = TextEditingController();
|
|
|
|
@override
|
|
void dispose() {
|
|
super.dispose();
|
|
_hostCtrl.dispose();
|
|
_portCtrl.dispose();
|
|
}
|
|
|
|
@override
|
|
Widget build(BuildContext context) {
|
|
return Scaffold(
|
|
appBar: CustomAppBar(title: const Text('iperf')),
|
|
body: _buildBody(),
|
|
floatingActionButton: _buildFAB(),
|
|
);
|
|
}
|
|
|
|
Widget _buildFAB() {
|
|
return FloatingActionButton(
|
|
heroTag: 'iperf',
|
|
child: const Icon(Icons.send),
|
|
onPressed: () {
|
|
if (_hostCtrl.text.isEmpty || _portCtrl.text.isEmpty) {
|
|
context.showSnackBar(libL10n.empty);
|
|
return;
|
|
}
|
|
final args = SshPageArgs(
|
|
spi: widget.args.spi,
|
|
initCmd: 'iperf -c ${_hostCtrl.text} -p ${_portCtrl.text}',
|
|
);
|
|
SSHPage.route.go(context, args);
|
|
},
|
|
);
|
|
}
|
|
|
|
Widget _buildBody() {
|
|
return ListView(
|
|
padding: const EdgeInsets.symmetric(horizontal: 17),
|
|
children: [
|
|
Input(controller: _hostCtrl, label: l10n.host, icon: Icons.computer, suggestion: false),
|
|
Input(
|
|
controller: _portCtrl,
|
|
label: l10n.port,
|
|
type: TextInputType.number,
|
|
icon: Icons.numbers,
|
|
suggestion: false,
|
|
),
|
|
],
|
|
);
|
|
}
|
|
}
|