mirror of
https://github.com/lollipopkit/flutter_server_box.git
synced 2025-12-17 15:24:35 +01:00
* feat: win compatibility * fix * fix: uptime parse * opt.: linux uptime accuracy * fix: windows temperature fetching * opt. * opt.: powershell exec * refactor: address PR review feedback and improve code quality ### Major Improvements: - **Refactored Windows status parsing**: Broke down large `_getWindowsStatus` method into 13 smaller, focused helper methods for better maintainability and readability - **Extracted system detection logic**: Created dedicated `SystemDetector` helper class to separate OS detection concerns from ServerProvider - **Improved concurrency handling**: Implemented proper synchronization for server updates using Future-based locks to prevent race conditions ### Bug Fixes: - **Fixed CPU percentage parsing**: Removed incorrect '*100' multiplication in BSD CPU parsing (values were already percentages) - **Enhanced memory parsing**: Added validation and error handling to BSD memory fallback parsing with proper logging - **Improved uptime parsing**: Added support for multiple Windows date formats and robust error handling with validation - **Fixed division by zero**: Added safety checks in Swap.usedPercent getter ### Code Quality Enhancements: - **Added comprehensive documentation**: Documented Windows CPU counter limitations and approach - **Strengthened error handling**: Added detailed logging and validation throughout parsing methods - **Improved robustness**: Enhanced BSD CPU parsing with percentage validation and warnings - **Better separation of concerns**: Each parsing method now has single responsibility ### Files Changed: - `lib/data/helper/system_detector.dart` (new): System detection helper - `lib/data/model/server/cpu.dart`: Fixed percentage parsing and added validation - `lib/data/model/server/memory.dart`: Enhanced fallback parsing and division-by-zero protection - `lib/data/model/server/server_status_update_req.dart`: Refactored into 13 focused parsing methods - `lib/data/provider/server.dart`: Improved synchronization and extracted system detection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: parse & shell fn struct --------- Co-authored-by: Claude <noreply@anthropic.com>
33 lines
1.4 KiB
Dart
33 lines
1.4 KiB
Dart
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:server_box/data/model/container/ps.dart';
|
|
|
|
void main() {
|
|
test('docker ps parse', () {
|
|
const raw = '''
|
|
CONTAINER ID STATUS NAMES IMAGE
|
|
0e9e2ef860d2 Up 2 hours hbbs rustdesk/rustdesk-server:latest
|
|
9a4df3ed340c Up 41 minutes hbbr rustdesk/rustdesk-server:latest
|
|
fa1215b4be74 Up 12 hours firefly uusec/firefly:latest
|
|
''';
|
|
final lines = raw.split('\n');
|
|
const ids = ['0e9e2ef860d2', '9a4df3ed340c', 'fa1215b4be74'];
|
|
const names = ['hbbs', 'hbbr', 'firefly'];
|
|
const images = [
|
|
'rustdesk/rustdesk-server:latest',
|
|
'rustdesk/rustdesk-server:latest',
|
|
'uusec/firefly:latest',
|
|
];
|
|
const states = ['Up 2 hours', 'Up 41 minutes', 'Up 12 hours'];
|
|
for (var idx = 1; idx < lines.length; idx++) {
|
|
final raw = lines[idx];
|
|
if (raw.isEmpty) continue;
|
|
final ps = DockerPs.parse(raw);
|
|
expect(ps.id, ids[idx - 1]);
|
|
expect(ps.names, names[idx - 1]);
|
|
expect(ps.image, images[idx - 1]);
|
|
expect(ps.state, states[idx - 1]);
|
|
expect(ps.running, true);
|
|
}
|
|
});
|
|
}
|