mirror of
https://github.com/lollipopkit/flutter_server_box.git
synced 2025-12-17 07:14:28 +01:00
* feat: win compatibility * fix * fix: uptime parse * opt.: linux uptime accuracy * fix: windows temperature fetching * opt. * opt.: powershell exec * refactor: address PR review feedback and improve code quality ### Major Improvements: - **Refactored Windows status parsing**: Broke down large `_getWindowsStatus` method into 13 smaller, focused helper methods for better maintainability and readability - **Extracted system detection logic**: Created dedicated `SystemDetector` helper class to separate OS detection concerns from ServerProvider - **Improved concurrency handling**: Implemented proper synchronization for server updates using Future-based locks to prevent race conditions ### Bug Fixes: - **Fixed CPU percentage parsing**: Removed incorrect '*100' multiplication in BSD CPU parsing (values were already percentages) - **Enhanced memory parsing**: Added validation and error handling to BSD memory fallback parsing with proper logging - **Improved uptime parsing**: Added support for multiple Windows date formats and robust error handling with validation - **Fixed division by zero**: Added safety checks in Swap.usedPercent getter ### Code Quality Enhancements: - **Added comprehensive documentation**: Documented Windows CPU counter limitations and approach - **Strengthened error handling**: Added detailed logging and validation throughout parsing methods - **Improved robustness**: Enhanced BSD CPU parsing with percentage validation and warnings - **Better separation of concerns**: Each parsing method now has single responsibility ### Files Changed: - `lib/data/helper/system_detector.dart` (new): System detection helper - `lib/data/model/server/cpu.dart`: Fixed percentage parsing and added validation - `lib/data/model/server/memory.dart`: Enhanced fallback parsing and division-by-zero protection - `lib/data/model/server/server_status_update_req.dart`: Refactored into 13 focused parsing methods - `lib/data/provider/server.dart`: Improved synchronization and extracted system detection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: parse & shell fn struct --------- Co-authored-by: Claude <noreply@anthropic.com>
45 lines
1.4 KiB
Dart
45 lines
1.4 KiB
Dart
import 'dart:io';
|
|
|
|
import 'package:json_annotation/json_annotation.dart';
|
|
import 'package:wake_on_lan/wake_on_lan.dart';
|
|
|
|
part 'wol_cfg.g.dart';
|
|
|
|
@JsonSerializable(includeIfNull: false)
|
|
final class WakeOnLanCfg {
|
|
final String mac;
|
|
final String ip;
|
|
final String? pwd;
|
|
|
|
const WakeOnLanCfg({required this.mac, required this.ip, this.pwd});
|
|
|
|
(Object?, bool) validate() {
|
|
final macValidation = MACAddress.validate(mac);
|
|
final ipValidation = IPAddress.validate(
|
|
ip,
|
|
type: ip.contains(':') ? InternetAddressType.IPv6 : InternetAddressType.IPv4,
|
|
);
|
|
final pwdValidation = pwd != null ? SecureONPassword.validate(pwd) : (state: true, error: null);
|
|
|
|
final valid = macValidation.state && ipValidation.state && pwdValidation.state;
|
|
final err = macValidation.error ?? ipValidation.error ?? pwdValidation.error;
|
|
return (err, valid);
|
|
}
|
|
|
|
Future<void> wake() {
|
|
if (!validate().$2) {
|
|
throw Exception('Invalid WakeOnLanCfg');
|
|
}
|
|
|
|
final ip_ = IPAddress(ip);
|
|
final mac_ = MACAddress(mac);
|
|
final pwd_ = pwd != null ? SecureONPassword(pwd!) : null;
|
|
final obj = WakeOnLAN(ip_, mac_, password: pwd_);
|
|
return obj.wake(repeat: 3, repeatDelay: const Duration(milliseconds: 500));
|
|
}
|
|
|
|
factory WakeOnLanCfg.fromJson(Map<String, dynamic> json) => _$WakeOnLanCfgFromJson(json);
|
|
|
|
Map<String, dynamic> toJson() => _$WakeOnLanCfgToJson(this);
|
|
}
|