mirror of
https://github.com/lollipopkit/flutter_server_box.git
synced 2025-12-16 23:04:22 +01:00
* feat: win compatibility * fix * fix: uptime parse * opt.: linux uptime accuracy * fix: windows temperature fetching * opt. * opt.: powershell exec * refactor: address PR review feedback and improve code quality ### Major Improvements: - **Refactored Windows status parsing**: Broke down large `_getWindowsStatus` method into 13 smaller, focused helper methods for better maintainability and readability - **Extracted system detection logic**: Created dedicated `SystemDetector` helper class to separate OS detection concerns from ServerProvider - **Improved concurrency handling**: Implemented proper synchronization for server updates using Future-based locks to prevent race conditions ### Bug Fixes: - **Fixed CPU percentage parsing**: Removed incorrect '*100' multiplication in BSD CPU parsing (values were already percentages) - **Enhanced memory parsing**: Added validation and error handling to BSD memory fallback parsing with proper logging - **Improved uptime parsing**: Added support for multiple Windows date formats and robust error handling with validation - **Fixed division by zero**: Added safety checks in Swap.usedPercent getter ### Code Quality Enhancements: - **Added comprehensive documentation**: Documented Windows CPU counter limitations and approach - **Strengthened error handling**: Added detailed logging and validation throughout parsing methods - **Improved robustness**: Enhanced BSD CPU parsing with percentage validation and warnings - **Better separation of concerns**: Each parsing method now has single responsibility ### Files Changed: - `lib/data/helper/system_detector.dart` (new): System detection helper - `lib/data/model/server/cpu.dart`: Fixed percentage parsing and added validation - `lib/data/model/server/memory.dart`: Enhanced fallback parsing and division-by-zero protection - `lib/data/model/server/server_status_update_req.dart`: Refactored into 13 focused parsing methods - `lib/data/provider/server.dart`: Improved synchronization and extracted system detection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: parse & shell fn struct --------- Co-authored-by: Claude <noreply@anthropic.com>
87 lines
2.0 KiB
Dart
87 lines
2.0 KiB
Dart
part of 'worker.dart';
|
|
|
|
class SftpReq {
|
|
final Spi spi;
|
|
final String remotePath;
|
|
final String localPath;
|
|
final SftpReqType type;
|
|
String? privateKey;
|
|
Spi? jumpSpi;
|
|
String? jumpPrivateKey;
|
|
|
|
SftpReq(this.spi, this.remotePath, this.localPath, this.type) {
|
|
final keyId = spi.keyId;
|
|
if (keyId != null) {
|
|
privateKey = getPrivateKey(keyId);
|
|
}
|
|
if (spi.jumpId != null) {
|
|
jumpSpi = Stores.server.box.get(spi.jumpId);
|
|
jumpPrivateKey = Stores.key.fetchOne(jumpSpi?.keyId)?.key;
|
|
}
|
|
}
|
|
}
|
|
|
|
enum SftpReqType { download, upload }
|
|
|
|
class SftpReqStatus {
|
|
final int id;
|
|
final SftpReq req;
|
|
final void Function() notifyListeners;
|
|
late SftpWorker worker;
|
|
final Completer? completer;
|
|
|
|
String get fileName => req.localPath.split('/').last;
|
|
|
|
// status of the download
|
|
double? progress;
|
|
SftpWorkerStatus? status;
|
|
int? size;
|
|
Exception? error;
|
|
Duration? spentTime;
|
|
|
|
SftpReqStatus({required this.req, required this.notifyListeners, this.completer})
|
|
: id = DateTime.now().microsecondsSinceEpoch {
|
|
worker = SftpWorker(onNotify: onNotify, req: req)..init();
|
|
}
|
|
|
|
@override
|
|
bool operator ==(Object other) => other is SftpReqStatus && id == other.id;
|
|
|
|
@override
|
|
int get hashCode => id ^ super.hashCode;
|
|
|
|
void dispose() {
|
|
worker._dispose();
|
|
completer?.complete(true);
|
|
}
|
|
|
|
void onNotify(dynamic event) {
|
|
var shouldDispose = false;
|
|
switch (event) {
|
|
case final SftpWorkerStatus val:
|
|
status = val;
|
|
if (status == SftpWorkerStatus.finished) {
|
|
dispose();
|
|
}
|
|
break;
|
|
case final double val:
|
|
progress = val;
|
|
break;
|
|
case final int val:
|
|
size = val;
|
|
break;
|
|
case final Duration d:
|
|
spentTime = d;
|
|
break;
|
|
default:
|
|
error = Exception('sftp worker event: $event');
|
|
Loggers.app.warning(error);
|
|
shouldDispose = true;
|
|
}
|
|
notifyListeners();
|
|
if (shouldDispose) dispose();
|
|
}
|
|
}
|
|
|
|
enum SftpWorkerStatus { preparing, sshConnectted, loading, finished }
|