Files
flutter_server_box/lib/data/model/pkg/manager.dart
lollipopkit🏳️‍⚧️ 3a615449e3 feat: Windows compatibility (#836)
* feat: win compatibility

* fix

* fix: uptime parse

* opt.: linux uptime accuracy

* fix: windows temperature fetching

* opt.

* opt.: powershell exec

* refactor: address PR review feedback and improve code quality

### Major Improvements:
- **Refactored Windows status parsing**: Broke down large `_getWindowsStatus` method into 13 smaller, focused helper methods for better maintainability and readability
- **Extracted system detection logic**: Created dedicated `SystemDetector` helper class to separate OS detection concerns from ServerProvider
- **Improved concurrency handling**: Implemented proper synchronization for server updates using Future-based locks to prevent race conditions

### Bug Fixes:
- **Fixed CPU percentage parsing**: Removed incorrect '*100' multiplication in BSD CPU parsing (values were already percentages)
- **Enhanced memory parsing**: Added validation and error handling to BSD memory fallback parsing with proper logging
- **Improved uptime parsing**: Added support for multiple Windows date formats and robust error handling with validation
- **Fixed division by zero**: Added safety checks in Swap.usedPercent getter

### Code Quality Enhancements:
- **Added comprehensive documentation**: Documented Windows CPU counter limitations and approach
- **Strengthened error handling**: Added detailed logging and validation throughout parsing methods
- **Improved robustness**: Enhanced BSD CPU parsing with percentage validation and warnings
- **Better separation of concerns**: Each parsing method now has single responsibility

### Files Changed:
- `lib/data/helper/system_detector.dart` (new): System detection helper
- `lib/data/model/server/cpu.dart`: Fixed percentage parsing and added validation
- `lib/data/model/server/memory.dart`: Enhanced fallback parsing and division-by-zero protection
- `lib/data/model/server/server_status_update_req.dart`: Refactored into 13 focused parsing methods
- `lib/data/provider/server.dart`: Improved synchronization and extracted system detection

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* refactor: parse & shell fn struct

---------

Co-authored-by: Claude <noreply@anthropic.com>
2025-08-08 16:56:36 +08:00

118 lines
3.0 KiB
Dart

import 'package:server_box/data/model/server/dist.dart';
enum PkgManager {
apt,
yum,
zypper,
pacman,
opkg,
apk;
String? get listUpdate {
switch (this) {
case PkgManager.yum:
return 'yum check-update';
case PkgManager.apt:
return 'apt list --upgradeable';
case PkgManager.zypper:
return 'zypper lu';
case PkgManager.pacman:
return 'pacman -Qu';
case PkgManager.opkg:
return 'opkg list-upgradable';
case PkgManager.apk:
return 'apk list --upgradable';
}
}
String? get update {
switch (this) {
case PkgManager.apt:
return 'apt update';
case PkgManager.pacman:
return 'pacman -Sy';
case PkgManager.opkg:
return 'opkg update';
case PkgManager.apk:
return 'apk update';
default:
return null;
}
}
String? upgrade(String args) {
switch (this) {
case PkgManager.yum:
return 'yum upgrade -y';
case PkgManager.apt:
return 'apt upgrade -y';
case PkgManager.zypper:
return 'zypper up -y';
case PkgManager.pacman:
return 'pacman -Syu --noconfirm';
case PkgManager.opkg:
return 'opkg upgrade $args';
case PkgManager.apk:
return 'apk upgrade';
}
}
List<String> updateListRemoveUnused(List<String> list) {
switch (this) {
case PkgManager.yum:
list = list.sublist(2);
list.removeWhere((element) => element.isEmpty);
final endLine = list.lastIndexWhere((element) => element.contains('Obsoleting Packages'));
if (endLine != -1 && list.isNotEmpty) {
list = list.sublist(0, endLine);
}
break;
case PkgManager.apt:
// avoid other outputs
// such as: [Could not chdir to home directory /home/test: No such file or directory, , WARNING: apt does not have a stable CLI interface. Use with caution in scripts., , Listing...]
final idx = list.indexWhere((element) => element.contains('[upgradable from:'));
if (idx == -1) {
return [];
}
list = list.sublist(idx);
list.removeWhere((element) => element.isEmpty);
break;
case PkgManager.zypper:
list = list.sublist(4);
break;
case PkgManager.pacman:
case PkgManager.opkg:
case PkgManager.apk:
break;
}
list.removeWhere((element) => element.isEmpty);
return list;
}
static PkgManager? fromDist(Dist? dist) {
switch (dist) {
case Dist.centos:
case Dist.rocky:
case Dist.fedora:
return PkgManager.yum;
case Dist.debian:
case Dist.ubuntu:
case Dist.kali:
case Dist.armbian:
case Dist.deepin:
return PkgManager.apt;
case Dist.opensuse:
return PkgManager.zypper;
case Dist.coreelec:
case Dist.wrt:
return PkgManager.opkg;
case Dist.arch:
return PkgManager.pacman;
case Dist.alpine:
return PkgManager.apk;
case null:
return null;
}
}
}