mirror of
https://github.com/lollipopkit/flutter_server_box.git
synced 2025-12-16 23:04:22 +01:00
3a615449e3
* feat: win compatibility * fix * fix: uptime parse * opt.: linux uptime accuracy * fix: windows temperature fetching * opt. * opt.: powershell exec * refactor: address PR review feedback and improve code quality ### Major Improvements: - **Refactored Windows status parsing**: Broke down large `_getWindowsStatus` method into 13 smaller, focused helper methods for better maintainability and readability - **Extracted system detection logic**: Created dedicated `SystemDetector` helper class to separate OS detection concerns from ServerProvider - **Improved concurrency handling**: Implemented proper synchronization for server updates using Future-based locks to prevent race conditions ### Bug Fixes: - **Fixed CPU percentage parsing**: Removed incorrect '*100' multiplication in BSD CPU parsing (values were already percentages) - **Enhanced memory parsing**: Added validation and error handling to BSD memory fallback parsing with proper logging - **Improved uptime parsing**: Added support for multiple Windows date formats and robust error handling with validation - **Fixed division by zero**: Added safety checks in Swap.usedPercent getter ### Code Quality Enhancements: - **Added comprehensive documentation**: Documented Windows CPU counter limitations and approach - **Strengthened error handling**: Added detailed logging and validation throughout parsing methods - **Improved robustness**: Enhanced BSD CPU parsing with percentage validation and warnings - **Better separation of concerns**: Each parsing method now has single responsibility ### Files Changed: - `lib/data/helper/system_detector.dart` (new): System detection helper - `lib/data/model/server/cpu.dart`: Fixed percentage parsing and added validation - `lib/data/model/server/memory.dart`: Enhanced fallback parsing and division-by-zero protection - `lib/data/model/server/server_status_update_req.dart`: Refactored into 13 focused parsing methods - `lib/data/provider/server.dart`: Improved synchronization and extracted system detection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: parse & shell fn struct --------- Co-authored-by: Claude <noreply@anthropic.com>
97 lines
2.9 KiB
Dart
97 lines
2.9 KiB
Dart
import 'package:fl_lib/fl_lib.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:icons_plus/icons_plus.dart';
|
|
import 'package:server_box/core/extension/context/locale.dart';
|
|
import 'package:server_box/view/page/server/tab/tab.dart';
|
|
// import 'package:server_box/view/page/setting/entry.dart';
|
|
import 'package:server_box/view/page/snippet/list.dart';
|
|
import 'package:server_box/view/page/ssh/tab.dart';
|
|
import 'package:server_box/view/page/storage/local.dart';
|
|
|
|
enum AppTab {
|
|
server,
|
|
ssh,
|
|
file,
|
|
snippet
|
|
//settings,
|
|
;
|
|
|
|
Widget get page {
|
|
return switch (this) {
|
|
server => const ServerPage(),
|
|
//settings => const SettingsPage(),
|
|
ssh => const SSHTabPage(),
|
|
file => const LocalFilePage(),
|
|
snippet => const SnippetListPage(),
|
|
};
|
|
}
|
|
|
|
NavigationDestination get navDestination {
|
|
return switch (this) {
|
|
server => NavigationDestination(
|
|
icon: const Icon(BoxIcons.bx_server),
|
|
label: l10n.server,
|
|
selectedIcon: const Icon(BoxIcons.bxs_server),
|
|
),
|
|
// settings => NavigationDestination(
|
|
// icon: const Icon(Icons.settings),
|
|
// label: libL10n.setting,
|
|
// selectedIcon: const Icon(Icons.settings),
|
|
// ),
|
|
ssh => const NavigationDestination(
|
|
icon: Icon(Icons.terminal_outlined),
|
|
label: 'SSH',
|
|
selectedIcon: Icon(Icons.terminal),
|
|
),
|
|
snippet => NavigationDestination(
|
|
icon: const Icon(Icons.code),
|
|
label: l10n.snippet,
|
|
selectedIcon: const Icon(Icons.code),
|
|
),
|
|
file => NavigationDestination(
|
|
icon: const Icon(Icons.folder_open),
|
|
label: libL10n.file,
|
|
selectedIcon: const Icon(Icons.folder),
|
|
),
|
|
};
|
|
}
|
|
|
|
NavigationRailDestination get navRailDestination {
|
|
return switch (this) {
|
|
server => NavigationRailDestination(
|
|
icon: const Icon(BoxIcons.bx_server),
|
|
label: Text(l10n.server),
|
|
selectedIcon: const Icon(BoxIcons.bxs_server),
|
|
),
|
|
// settings => NavigationRailDestination(
|
|
// icon: const Icon(Icons.settings),
|
|
// label: libL10n.setting,
|
|
// selectedIcon: const Icon(Icons.settings),
|
|
// ),
|
|
ssh => const NavigationRailDestination(
|
|
icon: Icon(Icons.terminal_outlined),
|
|
label: Text('SSH'),
|
|
selectedIcon: Icon(Icons.terminal),
|
|
),
|
|
snippet => NavigationRailDestination(
|
|
icon: const Icon(Icons.code),
|
|
label: Text(l10n.snippet),
|
|
selectedIcon: const Icon(Icons.code),
|
|
),
|
|
file => NavigationRailDestination(
|
|
icon: const Icon(Icons.folder_open),
|
|
label: Text(libL10n.file),
|
|
selectedIcon: const Icon(Icons.folder),
|
|
),
|
|
};
|
|
}
|
|
|
|
static List<NavigationDestination> get navDestinations {
|
|
return AppTab.values.map((e) => e.navDestination).toList();
|
|
}
|
|
|
|
static List<NavigationRailDestination> get navRailDestinations {
|
|
return AppTab.values.map((e) => e.navRailDestination).toList();
|
|
}
|
|
}
|