bug: incorrect disk smart info (#789)

lib/data/model/app/shell_func.dart

@@ -225,7 +225,7 @@ enum StatusCmdType {
   ),
   nvidia._('nvidia-smi -q -x'),
   sensors._('sensors'),
-  diskSmart._('for d in \$(lsblk -dn -o KNAME); do smartctl -j /dev/\$d; echo; done'),
+  diskSmart._('for d in \$(lsblk -dn -o KNAME); do smartctl -a -j /dev/\$d; echo; done'),
   cpuBrand._('cat /proc/cpuinfo | grep "model name"');
 
   final String cmd;

lib/data/model/server/disk_smart.dart

@@ -35,7 +35,10 @@ abstract class DiskSmart with _$DiskSmart {
 
         // Basic
         final device = data['device']?['name']?.toString() ?? '';
-        final healthy = data['smart_status']?['passed'] as bool?;
+
+        if (!_isPhysicalDisk(device)) continue;
+
+        final healthy = _parseHealthStatus(data);
 
         // Model and Serial
         final model =
@@ -72,6 +75,92 @@ abstract class DiskSmart with _$DiskSmart {
     return results;
   }
 
+  static bool _isPhysicalDisk(String device) {
+    if (device.isEmpty) return false;
+
+    // Common patterns for physical disks
+    final patterns = [
+      RegExp(r'^/dev/sd[a-z]$'), // SATA/SCSI: /dev/sda, /dev/sdb
+      RegExp(r'^/dev/hd[a-z]$'), // IDE: /dev/hda, /dev/hdb
+      RegExp(r'^/dev/nvme\d+n\d+$'), // NVMe: /dev/nvme0n1, /dev/nvme1n1
+      RegExp(r'^/dev/mmcblk\d+$'), // MMC: /dev/mmcblk0
+      RegExp(r'^/dev/vd[a-z]$'), // VirtIO: /dev/vda, /dev/vdb
+      RegExp(r'^/dev/xvd[a-z]$'), // Xen: /dev/xvda, /dev/xvdb
+    ];
+
+    return patterns.any((pattern) => pattern.hasMatch(device));
+  }
+
+  static bool? _parseHealthStatus(Map<String, dynamic> data) {
+    // smart_status.passed
+    final smartStatus = data['smart_status'];
+    if (smartStatus is Map<String, dynamic>) {
+      final passed = smartStatus['passed'];
+      if (passed is bool) return passed;
+    }
+
+    // smart_status.status
+    if (smartStatus is Map<String, dynamic>) {
+      final status = smartStatus['status']?.toString().toLowerCase();
+      if (status != null) {
+        if (status.contains('pass') || status.contains('ok')) return true;
+        if (status.contains('fail')) return false;
+      }
+    }
+
+    // smart_status
+    final rootSmartStatus = data['smart_status']?.toString().toLowerCase();
+    if (rootSmartStatus != null) {
+      if (rootSmartStatus.contains('pass') || rootSmartStatus.contains('ok')) return true;
+      if (rootSmartStatus.contains('fail')) return false;
+    }
+
+    // health attrs
+    final attrTable = data['ata_smart_attributes']?['table'] as List?;
+    if (attrTable != null) {
+      var hasFailingAttributes = false;
+
+      for (final attr in attrTable) {
+        if (attr is Map<String, dynamic>) {
+          final whenFailed = attr['when_failed']?.toString();
+          if (whenFailed != null && whenFailed.isNotEmpty && whenFailed != 'never') {
+            hasFailingAttributes = true;
+            break;
+          }
+
+          // Whether the attribute is critical
+          final name = attr['name']?.toString();
+          final value = attr['value'] as int?;
+          final thresh = attr['thresh'] as int?;
+
+          if (name != null && value != null && thresh != null && thresh > 0) {
+            const criticalAttrs = [
+              'Reallocated_Sector_Ct',
+              'Reallocated_Event_Count',
+              'Current_Pending_Sector',
+              'Offline_Uncorrectable',
+              'UDMA_CRC_Error_Count',
+            ];
+
+            if (criticalAttrs.contains(name) && value < thresh) {
+              hasFailingAttributes = true;
+              break;
+            }
+          }
+        }
+      }
+
+      if (hasFailingAttributes) return false;
+    }
+
+    if (attrTable != null && attrTable.isNotEmpty) {
+      return true;
+    }
+
+    // Uncertain status, assume healthy
+    return true;
+  }
+
   static Map<String, SmartAttribute> _parseSmartAttributes(Map<String, dynamic> data) {
     final attributes = <String, SmartAttribute>{};
 

lib/view/page/server/detail/view.dart

@@ -580,38 +580,133 @@ class _ServerDetailPageState extends State<ServerDetailPage> with SingleTickerPr
   }
 
   Widget _buildDiskSmartItem(DiskSmart smart) {
-    final isPass = smart.healthy ?? false;
-    final statusText = isPass ? 'PASS' : 'FAIL';
-    final statusColor = isPass ? Colors.green : Colors.red;
-    final statusIcon = isPass
-        ? Icon(Icons.check_circle, color: Colors.green, size: 18)
-        : Icon(Icons.error, color: Colors.red, size: 18);
+    final healthStatus = _getDiskHealthStatus(smart);
 
     return ListTile(
       dense: true,
-      contentPadding: const EdgeInsets.symmetric(horizontal: 8, vertical: 0),
-      leading: statusIcon,
+      leading: healthStatus.icon,
       title: Text(smart.device, style: UIs.text13, textScaler: _textFactor),
       trailing: Text(
-        statusText,
-        style: UIs.text13.copyWith(color: statusColor, fontWeight: FontWeight.bold),
+        healthStatus.text,
+        style: UIs.text13.copyWith(fontWeight: FontWeight.bold),
         textScaler: _textFactor,
       ),
       subtitle: _buildDiskSmartDetails(smart),
+      onTap: () => _onTapDiskSmartItem(smart),
     );
   }
 
+  ({String text, Color color, Widget icon}) _getDiskHealthStatus(DiskSmart smart) {
+    if (smart.healthy == null) {
+      return (
+        text: libL10n.unknown,
+        color: Colors.orange,
+        icon: const Icon(Icons.help_outline, color: Colors.orange, size: 18),
+      );
+    } else if (smart.healthy!) {
+      return (
+        text: 'PASS',
+        color: Colors.green,
+        icon: const Icon(Icons.check_circle, color: Colors.green, size: 18),
+      );
+    } else {
+      return (text: 'FAIL', color: Colors.red, icon: const Icon(Icons.error, color: Colors.red, size: 18));
+    }
+  }
+
   Widget? _buildDiskSmartDetails(DiskSmart smart) {
     final details = <String>[];
-    
-    if (smart.model != null) details.add(smart.model!);
-    if (smart.serial != null) details.add('S/N: ${smart.serial}');
-    if (smart.temperature != null) details.add('${smart.temperature!.toStringAsFixed(1)}°C');
-    if (smart.powerOnHours != null) details.add('${smart.powerOnHours} hours');
-    
+
+    if (smart.model != null) {
+      details.add(smart.model!);
+    }
+
+    if (smart.temperature != null) {
+      details.add('${smart.temperature!.toStringAsFixed(1)}°C');
+    }
+
+    if (smart.powerOnHours != null) {
+      final hours = smart.powerOnHours!;
+      details.add('$hours ${libL10n.hour}');
+    }
+
+    if (smart.ssdLifeLeft != null) {
+      details.add('Life left: ${smart.ssdLifeLeft}%');
+    }
+
     if (details.isEmpty) return null;
-    
-    return Text(details.join(' | '), style: UIs.text12, textScaler: _textFactor);
+
+    return Text(
+      details.join(' | '),
+      style: UIs.text12Grey,
+      textScaler: _textFactor,
+      maxLines: 2,
+      overflow: TextOverflow.ellipsis,
+    );
+  }
+
+  void _onTapDiskSmartItem(DiskSmart smart) {
+    final details = <String>[];
+
+    if (smart.model != null) details.add('Model: ${smart.model}');
+    if (smart.serial != null) details.add('Serial: ${smart.serial}');
+    if (smart.temperature != null) details.add('Temperature: ${smart.temperature!.toStringAsFixed(1)}°C');
+
+    if (smart.powerOnHours != null) {
+      details.add('Power On: ${smart.powerOnHours} ${libL10n.hour}');
+    }
+    if (smart.powerCycleCount != null) {
+      details.add('Power Cycle: ${smart.powerCycleCount}');
+    }
+
+    if (smart.ssdLifeLeft != null) {
+      details.add('Life Left: ${smart.ssdLifeLeft}%');
+    }
+    if (smart.lifetimeWritesGiB != null) {
+      details.add('Lifetime Write: ${smart.lifetimeWritesGiB} GiB');
+    }
+    if (smart.lifetimeReadsGiB != null) {
+      details.add('Lifetime Read: ${smart.lifetimeReadsGiB} GiB');
+    }
+    if (smart.averageEraseCount != null) {
+      details.add('Avg. Erase: ${smart.averageEraseCount}');
+    }
+    if (smart.unsafeShutdownCount != null) {
+      details.add('Unsafe Shutdown: ${smart.unsafeShutdownCount}');
+    }
+
+    final criticalAttrs = [
+      'Reallocated_Sector_Ct',
+      'Current_Pending_Sector',
+      'Offline_Uncorrectable',
+      'UDMA_CRC_Error_Count',
+    ];
+
+    for (final attrName in criticalAttrs) {
+      final attr = smart.getAttribute(attrName);
+      if (attr != null && attr.rawValue != null) {
+        final value = attr.rawValue.toString();
+        details.add('${attrName.replaceAll('_', ' ')}: $value');
+      }
+    }
+
+    if (details.isEmpty) {
+      return;
+    }
+
+    final markdown = details.join('\n\n- ');
+    context.showRoundDialog(
+      title: smart.device,
+      child: MarkdownBody(
+        data: '- $markdown',
+        selectable: true,
+        styleSheet: MarkdownStyleSheet.fromTheme(Theme.of(context)).copyWith(
+          p: UIs.text13Grey,
+          h2: UIs.text15,
+        ),
+      ),
+      actions: Btnx.oks,
+    );
   }
 
   Widget? _buildNetView(Server si) {