mirror of
https://github.com/lollipopkit/flutter_server_box.git
synced 2025-12-17 23:34:24 +01:00
feat: Windows compatibility (#836)
* feat: win compatibility * fix * fix: uptime parse * opt.: linux uptime accuracy * fix: windows temperature fetching * opt. * opt.: powershell exec * refactor: address PR review feedback and improve code quality ### Major Improvements: - **Refactored Windows status parsing**: Broke down large `_getWindowsStatus` method into 13 smaller, focused helper methods for better maintainability and readability - **Extracted system detection logic**: Created dedicated `SystemDetector` helper class to separate OS detection concerns from ServerProvider - **Improved concurrency handling**: Implemented proper synchronization for server updates using Future-based locks to prevent race conditions ### Bug Fixes: - **Fixed CPU percentage parsing**: Removed incorrect '*100' multiplication in BSD CPU parsing (values were already percentages) - **Enhanced memory parsing**: Added validation and error handling to BSD memory fallback parsing with proper logging - **Improved uptime parsing**: Added support for multiple Windows date formats and robust error handling with validation - **Fixed division by zero**: Added safety checks in Swap.usedPercent getter ### Code Quality Enhancements: - **Added comprehensive documentation**: Documented Windows CPU counter limitations and approach - **Strengthened error handling**: Added detailed logging and validation throughout parsing methods - **Improved robustness**: Enhanced BSD CPU parsing with percentage validation and warnings - **Better separation of concerns**: Each parsing method now has single responsibility ### Files Changed: - `lib/data/helper/system_detector.dart` (new): System detection helper - `lib/data/model/server/cpu.dart`: Fixed percentage parsing and added validation - `lib/data/model/server/memory.dart`: Enhanced fallback parsing and division-by-zero protection - `lib/data/model/server/server_status_update_req.dart`: Refactored into 13 focused parsing methods - `lib/data/provider/server.dart`: Improved synchronization and extracted system detection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: parse & shell fn struct --------- Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -6,11 +6,7 @@ final class UnixPermOp {
|
||||
final bool w;
|
||||
final bool x;
|
||||
|
||||
const UnixPermOp({
|
||||
required this.r,
|
||||
required this.w,
|
||||
required this.x,
|
||||
});
|
||||
const UnixPermOp({required this.r, required this.w, required this.x});
|
||||
|
||||
UnixPermOp copyWith({bool? r, bool? w, bool? x}) {
|
||||
return UnixPermOp(r: r ?? this.r, w: w ?? this.w, x: x ?? this.x);
|
||||
@@ -24,8 +20,7 @@ final class UnixPermOp {
|
||||
enum UnixPermScope {
|
||||
user,
|
||||
group,
|
||||
other,
|
||||
;
|
||||
other;
|
||||
|
||||
String get title {
|
||||
return switch (this) {
|
||||
@@ -72,10 +67,10 @@ final class UnixPerm {
|
||||
}
|
||||
|
||||
static UnixPerm get empty => const UnixPerm(
|
||||
user: UnixPermOp(r: false, w: false, x: false),
|
||||
group: UnixPermOp(r: false, w: false, x: false),
|
||||
other: UnixPermOp(r: false, w: false, x: false),
|
||||
);
|
||||
user: UnixPermOp(r: false, w: false, x: false),
|
||||
group: UnixPermOp(r: false, w: false, x: false),
|
||||
other: UnixPermOp(r: false, w: false, x: false),
|
||||
);
|
||||
}
|
||||
|
||||
final class UnixPermEditor extends StatefulWidget {
|
||||
@@ -150,9 +145,6 @@ final class _UnixPermEditorState extends State<UnixPermEditor> {
|
||||
}
|
||||
|
||||
Widget _buildSwitch(bool value, void Function(bool) onChanged) {
|
||||
return Switch(
|
||||
value: value,
|
||||
onChanged: onChanged,
|
||||
);
|
||||
return Switch(value: value, onChanged: onChanged);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user