From 692644a74b8528470249f5cefe5b28d6e1708f2c Mon Sep 17 00:00:00 2001
From: conduition <conduition@proton.me>
Date: Sun, 18 Feb 2024 21:45:46 +0000
Subject: [PATCH] avoid using Into<Scalar> in internal methods

---
 src/contract/outcome.rs | 3 +--
 src/contract/split.rs   | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/contract/outcome.rs b/src/contract/outcome.rs
index 84ee9ac..c0967fe 100644
--- a/src/contract/outcome.rs
+++ b/src/contract/outcome.rs
@@ -100,7 +100,7 @@ pub(crate) fn build_outcome_txs(
 pub(crate) fn partial_sign_outcome_txs<'a>(
     params: &ContractParameters,
     outcome_build_out: &OutcomeTransactionBuildOutput,
-    seckey: impl Into<Scalar>,
+    seckey: Scalar,
     secnonces: impl IntoIterator<Item = SecNonce>,
     aggnonces: impl IntoIterator<Item = &'a AggNonce>,
 ) -> Result<Vec<PartialSignature>, Error> {
@@ -108,7 +108,6 @@ pub(crate) fn partial_sign_outcome_txs<'a>(
     let funding_spend_info = &outcome_build_out.funding_spend_info;
 
     // Confirm the key is a part of the group.
-    let seckey = seckey.into();
     funding_spend_info
         .key_agg_ctx()
         .pubkey_index(seckey.base_point_mul())
diff --git a/src/contract/split.rs b/src/contract/split.rs
index 3bd9cb3..74f571e 100644
--- a/src/contract/split.rs
+++ b/src/contract/split.rs
@@ -123,11 +123,10 @@ pub(crate) fn partial_sign_split_txs<'a>(
     params: &ContractParameters,
     outcome_build_out: &OutcomeTransactionBuildOutput,
     split_build_out: &SplitTransactionBuildOutput,
-    seckey: impl Into<Scalar>,
+    seckey: Scalar,
     secnonces: impl IntoIterator<Item = SecNonce>,
     aggnonces: impl IntoIterator<Item = &'a AggNonce>,
 ) -> Result<BTreeMap<WinCondition, PartialSignature>, Error> {
-    let seckey = seckey.into();
     let pubkey = seckey.base_point_mul();
 
     let mut partial_signatures = BTreeMap::<WinCondition, PartialSignature>::new();