aljaz/cdk
1
0
Fork 0
mirror of https://github.com/aljazceru/cdk.git synced 2025-12-20 14:14:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Reorganize tests, add mint quote/payment coverage, and prevent over-issuing (#1048)

Browse Source 
* Add consistent ordering of sql migrations

Also sort the prefix and not only the filenames

* Reorganize tests, add mint quote/payment coverage, and prevent over-issuing

Reorganizes the mint test suite into clear modules, adds comprehensive mint
quote & payment scenarios, enhances the shared test macro, and hardens SQL
logic to forbid issuing more than what’s been paid.

These tests were added:

* Add quote once; reject duplicates.
* Register multiple payments and verify aggregated amount_paid.
* Read parity between DB and in-TX views.
* Reject duplicate payment_id in same and different transactions.
* Reject over-issuing (same TX, different TX, with/without prior payments).

---------

Co-authored-by: thesimplekid <tsk@thesimplekid.com>
This commit is contained in:
C
2025-09-08 10:55:41 -03:00
committed by GitHub
parent b5b8ee557c
commit 841e35d70f
6 changed files with 601 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
crates/cdk-sql-common/src/mint/mod.rs
View File

@@ -654,9 +654,9 @@ where
amount_issued: Amount,
) -> Result<Amount, Self::Err> {
// Get current amount_issued from quote
let current_amount = query(
let current_amounts = query(
r#"
SELECT amount_issued
SELECT amount_issued, amount_paid
FROM mint_quote
WHERE id = :quote_id
FOR UPDATE
@@ -667,20 +667,33 @@ where
.await
.inspect_err(|err| {
tracing::error!("SQLite could not get mint quote amount_issued: {}", err);
})?;
})?
.ok_or(Error::QuoteNotFound)?;
let current_amount_issued = if let Some(current_amount) = current_amount {
let amount: u64 = column_as_number!(current_amount[0].clone());
Amount::from(amount)
} else {
Amount::ZERO
let new_amount_issued = {
// Make sure the db protects issuing not paid quotes
unpack_into!(
let (current_amount_issued, current_amount_paid) = current_amounts
);
let current_amount_issued: u64 = column_as_number!(current_amount_issued);
let current_amount_paid: u64 = column_as_number!(current_amount_paid);
let current_amount_issued = Amount::from(current_amount_issued);
let current_amount_paid = Amount::from(current_amount_paid);
// Calculate new amount_issued with overflow check
let new_amount_issued = current_amount_issued
.checked_add(amount_issued)
.ok_or_else(|| database::Error::AmountOverflow)?;
current_amount_paid
.checked_sub(new_amount_issued)
.ok_or(Error::Internal("Over-issued not allowed".to_owned()))?;
new_amount_issued
};
// Calculate new amount_issued with overflow check
let new_amount_issued = current_amount_issued
.checked_add(amount_issued)
.ok_or_else(|| database::Error::AmountOverflow)?;
// Update the amount_issued
query(
r#"