aljaz/cdk
1
0
Fork 0
mirror of https://github.com/aljazceru/cdk.git synced 2025-12-19 05:35:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: remove delete fns for quotes (#1122)

Browse Source
This commit is contained in:
thesimplekid
2025-09-26 14:37:43 +01:00
committed by GitHub
parent f48660f344
commit 05acb914fe
3 changed files with 2 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/cdk-common/src/database/mint/mod.rs
View File

@@ -170,8 +170,7 @@ pub trait QuotesTransaction<'a> {
quote_id: &QuoteId, quote_id: &QuoteId,
amount_issued: Amount, amount_issued: Amount,
) -> Result<Amount, Self::Err>; ) -> Result<Amount, Self::Err>;
/// Remove [`MintMintQuote`]
async fn remove_mint_quote(&mut self, quote_id: &QuoteId) -> Result<(), Self::Err>;
/// Get [`mint::MeltQuote`] and lock it for update in this transaction /// Get [`mint::MeltQuote`] and lock it for update in this transaction
async fn get_melt_quote( async fn get_melt_quote(
&mut self, &mut self,
@@ -196,8 +195,7 @@ pub trait QuotesTransaction<'a> {
new_state: MeltQuoteState, new_state: MeltQuoteState,
payment_proof: Option<String>, payment_proof: Option<String>,
) -> Result<(MeltQuoteState, mint::MeltQuote), Self::Err>; ) -> Result<(MeltQuoteState, mint::MeltQuote), Self::Err>;
/// Remove [`mint::MeltQuote`]
async fn remove_melt_quote(&mut self, quote_id: &QuoteId) -> Result<(), Self::Err>;
/// Get all [`MintMintQuote`]s and lock it for update in this transaction /// Get all [`MintMintQuote`]s and lock it for update in this transaction
async fn get_mint_quote_by_request( async fn get_mint_quote_by_request(
&mut self, &mut self,

22
crates/cdk-sql-common/src/mint/mod.rs
View File

@@ -878,14 +878,6 @@ VALUES (:quote_id, :amount, :timestamp);
Ok(()) Ok(())
} }
async fn remove_mint_quote(&mut self, quote_id: &QuoteId) -> Result<(), Self::Err> {
query(r#"DELETE FROM mint_quote WHERE id=:id"#)?
.bind("id", quote_id.to_string())
.execute(&self.inner)
.await?;
Ok(())
}
async fn add_melt_quote(&mut self, quote: mint::MeltQuote) -> Result<(), Self::Err> { async fn add_melt_quote(&mut self, quote: mint::MeltQuote) -> Result<(), Self::Err> {
// Now insert the new quote // Now insert the new quote
query( query(
@@ -1020,20 +1012,6 @@ VALUES (:quote_id, :amount, :timestamp);
Ok((old_state, quote)) Ok((old_state, quote))
} }
async fn remove_melt_quote(&mut self, quote_id: &QuoteId) -> Result<(), Self::Err> {
query(
r#"
DELETE FROM melt_quote
WHERE id=:id
"#,
)?
.bind("id", quote_id.to_string())
.execute(&self.inner)
.await?;
Ok(())
}
async fn get_mint_quote(&mut self, quote_id: &QuoteId) -> Result<Option<MintQuote>, Self::Err> { async fn get_mint_quote(&mut self, quote_id: &QuoteId) -> Result<Option<MintQuote>, Self::Err> {
let payments = get_mint_quote_payments(&self.inner, quote_id).await?; let payments = get_mint_quote_payments(&self.inner, quote_id).await?;
let issuance = get_mint_quote_issuance(&self.inner, quote_id).await?; let issuance = get_mint_quote_issuance(&self.inner, quote_id).await?;

33
crates/cdk/src/mint/issue/mod.rs
View File

@@ -376,39 +376,6 @@ impl Mint {
result result
} }
/// Removes a mint quote from the database
///
/// # Arguments
/// * `quote_id` - The UUID of the quote to remove
///
/// # Returns
/// * `Ok(())` if removal was successful
/// * `Error` if the quote doesn't exist or removal fails
#[instrument(skip_all)]
pub async fn remove_mint_quote(&self, quote_id: &QuoteId) -> Result<(), Error> {
#[cfg(feature = "prometheus")]
METRICS.inc_in_flight_requests("remove_mint_quote");
let result = async {
let mut tx = self.localstore.begin_transaction().await?;
tx.remove_mint_quote(quote_id).await?;
tx.commit().await?;
Ok(())
}
.await;
#[cfg(feature = "prometheus")]
{
METRICS.dec_in_flight_requests("remove_mint_quote");
METRICS.record_mint_operation("remove_mint_quote", result.is_ok());
if result.is_err() {
METRICS.record_error();
}
}
result
}
/// Marks a mint quote as paid based on the payment request ID /// Marks a mint quote as paid based on the payment request ID
/// ///
/// Looks up the mint quote by the payment request ID and marks it as paid /// Looks up the mint quote by the payment request ID and marks it as paid