Commit Graph

2411 Commits

Author SHA1 Message Date
Nicolas Dorier
dd6c4c771e Include XPubs in PSBTs for multi sig (#6696) 2025-04-24 21:36:09 +09:00
nicolas.dorier
5df76b9c00 Make test less flaky 2025-04-23 16:51:56 +09:00
nicolas.dorier
5f908322c2 Make Rider a bit less verbose Code cleanup 2025-04-23 16:51:56 +09:00
Nicolas Dorier
b96491a804 Fix: PSBT Signing Option in MultiSig Server redirected incorrectly (fix #6668) (#6690) 2025-04-23 14:40:28 +09:00
Nicolas Dorier
8e9aead659 Automatically set Multisig Server if Output descriptor has several keys (#6688) 2025-04-22 17:01:55 +09:00
Nicolas Dorier
a2d94a265b Fix: No need to select the Signing Key for signing through multi sig process (#6674) 2025-04-21 17:11:50 +09:00
Nicolas Dorier
3d363baa9e Fix: Recreating an aborted TX in MultiSig on Server setup crashes (#6682) 2025-04-21 17:10:28 +09:00
Nicolas Dorier
2f26979ed7 Refactor vault (#6678)
* Use Blazor for the Vault code

* Put elements in different file

* Controller abstraction

* Break into VaultElement
2025-04-21 17:09:46 +09:00
Nicolas Dorier
bf277f03c4 Merge pull request #6675 from wbalbo/fix-add-confirmation-deletion-email-rules
Fix: adding a confirmation for the deletion of Email Rule
2025-04-21 00:02:24 +09:00
nicolas.dorier
892dda0d3b Fix tests 2025-04-20 23:48:03 +09:00
rockstardev
c3998fdf34 Addressing PR review issues 2025-04-16 10:49:08 +09:00
nicolas.dorier
586a952480 Index the paymentRequest's reference number in invoice search 2025-04-16 10:41:02 +09:00
rockstardev
6af8c865c7 Filtering by Title and Reference number 2025-04-16 10:41:02 +09:00
rockstardev
d2debaa842 Adding Reference Number to Payment Requests 2025-04-16 09:39:29 +09:00
nicolas.dorier
782d53c13d Fix: Impossible to edit a payment request after receiving an invoice on it 2025-04-11 15:36:51 +09:00
nicolas.dorier
95b976fb4b Restore behavior: Invite non existing users when adding a store user 2025-04-08 23:08:25 +09:00
Nicolas Dorier
73af6f4ff4 Do not automatically invite a user to the instance when inviting in a store (#6658) 2025-04-08 18:21:58 +09:00
d11n
1c921030dc Store users: Ensure the last owner cannot be downgraded (#6654)
* Store users: Ensure the last owner cannot be downgraded

Changes the behaviour of the `AddOrUpdateStoreUser` method to throw errors for the failure cases, so that the UI and API can report the actual problem. A role change might fail if the user already has that role or if they are the last owner of the store.

* Cleanup code

---------

Co-authored-by: nicolas.dorier <nicolas.dorier@gmail.com>
2025-04-08 17:21:07 +09:00
Nicolas Dorier
ce83e4d96d Fix: PaymentRequests created via API never expires (#6657) 2025-04-08 14:17:31 +09:00
nicolas.dorier
c373f1e08f Refactor UserService.IsDisabled to a property 2025-04-04 16:42:27 +09:00
nicolas.dorier
ead74a985f Remove deprecated properties 2025-04-04 16:28:44 +09:00
d11n
a916ae81be Greenfield: Expand user data (#6649) 2025-04-04 16:15:33 +09:00
Nicolas Dorier
658ddd1f27 Fix: Refunds through API were ignoring BOLT11 expiration at store level (#6644) 2025-03-31 09:32:12 +09:00
nicolas.dorier
631a0a22b5 Small nits 2025-03-27 16:08:15 +09:00
rockstardev
2e848797a3 Using CallbackGenerator as Nicolas requested 2025-03-26 23:08:48 -05:00
nicolas.dorier
d40359f12f Remove useless parameter from CollectSignature 2025-03-26 23:08:48 -05:00
rockstardev
acfd6059b1 Pending Transaction Webhook Providers foundation 2025-03-26 23:08:48 -05:00
Dennis Reimann
f45486f379 Invoice: More concise payment method related error messages
Makes the error messages clearer for the user and strips the timestamps, which are not necessary in this context.

Related: #6636.
2025-03-24 15:57:03 +01:00
rockstardev
55cdd63c44 Renaming methods to align with views 2025-03-23 09:04:11 -05:00
rockstardev
0d49594fe2 Fixing issue with Selenium tests 2025-03-23 09:04:11 -05:00
rockstardev
1b2dfb3e82 Removing legacy class 2025-03-23 09:04:11 -05:00
rockstardev
5ce8648bd2 Fixing tests 2025-03-23 09:04:10 -05:00
rockstardev
9cf25c7c9e Simplifying code 2025-03-23 09:04:10 -05:00
rockstardev
f0b0aa0c89 Starting dedicated pages for Email Rules 2025-03-23 09:04:10 -05:00
nicolas.dorier
c3c6473e35 Disable cold wallet creation by default 2025-03-13 19:23:23 +09:00
nicolas.dorier
2911771f19 Feature: RBF and UX improvement to fee bumping 2025-03-11 17:44:18 +09:00
rockstardev
9dcf8d3251 Display fiat amount previews in Transaction Details page (#6610)
* Code cleanup

* Preparing model to include data needed for fiat display

* Displaying fiat amount and allowing switching between it and BTC

* Restoring parts removed by vibe coding

* Making ToFiatAmount method work for in wider variety of cases

* Tweaks for display and negative values

* Calculating amounts on serverside and simplifying

* Fix warnings

---------

Co-authored-by: nicolas.dorier <nicolas.dorier@gmail.com>
2025-03-08 21:33:19 +09:00
ThiagoOyo
9bff84f90f Fix: Archived invoices shouldn't be browsable by non authenticated users (#6588)
* fix: return 403 when unauthenticated user accesses an archived invoice receipt

* refactor: simplify archived invoice access check with pattern matching

* Return 404 for unauthorized users accessing archived invoice

Co-authored-by: d11n <mail@dennisreimann.de>

* feat: add archived invoice validation for unauthenticated access in Checkout and GetStatus

* test: add test case for unauthorized access to archived invoice returning not found

* test: add unauthorized checkout test for archived invoice

* Commenting code and adding test case for GetStatus

---------

Co-authored-by: d11n <mail@dennisreimann.de>
Co-authored-by: rockstardev <5191402+rockstardev@users.noreply.github.com>
2025-03-06 17:45:53 +09:00
rockstardev
1da2cedffd Reverting changes, validate email only if it was provided 2025-03-05 22:49:07 -06:00
rockstardev
18852af241 Refactoring and commenting 2025-03-05 22:49:06 -06:00
rockstardev
8094800cfc IsMailboxAddress already checks for null, simplifying code 2025-03-05 22:49:06 -06:00
nicolas.dorier
be8ecb823e Refactor email endpoints 2025-03-05 22:49:06 -06:00
rockstardev
a7e3cbb105 Adding endpoint to set server email settings (#6601)
* Adding endpoint in Greenfield to allow server email settings

* Adding related swagger file

* Refactoring EmailSettingsData to be more readable

* Adding server email masking

* Adding tests

* Update BTCPayServer/wwwroot/swagger/v1/swagger.template.serveremail.json

Co-authored-by: d11n <mail@dennisreimann.de>

* Masking smtp server email returned over greenfield api and test

* Retaining password if password mask is used

* Remove magic string *****

* Flatten request for server's settings. Fix bug on shared setting instances

* Remove useless doc

* Simplify code

* Fix Store Email settings page

---------

Co-authored-by: d11n <mail@dennisreimann.de>
Co-authored-by: nicolas.dorier <nicolas.dorier@gmail.com>
2025-02-27 15:59:17 +09:00
rockstardev
8b5c5895f0 Selenium tests for Multisig on server (#6487)
* Adding MultisigTests

* Adding fetching of receive address and creating pending transaction

* Completing multisig test flow

* Reverting Selenium ChromeDriver version

* Adding generation of PSBTs

* Removing unnecessary lines

* PSBT test signing now working with multisig dervation scheme

* Updating SignTestPSBT test

* Reducing number of iterations for test funding, to speed up tests

* Bugfixing PSBT problem

* Ensuring that PSBT signing also works for pending transactions

* Ensuring we don't collect count duplicate signatures for same PSBTs

* Resolving bug in PendingTransactionService where Combine was modifying object

* Fixing bug where pending transaction was not broadcased if there was ReturnUrl

* Finally finishing Multisig Selenium test flow with signing PSBTs, broadcasting and cancelling them

* Small nit, waiting loaded element

* Nit: Use AssetElementNotFound

* Fix warning

* Remove code dups

---------

Co-authored-by: nicolas.dorier <nicolas.dorier@gmail.com>
2025-02-25 14:39:57 +09:00
René Aaron
039e613524 fix: remove lnurl description hash check 2025-01-28 14:57:44 +01:00
Nicolas Dorier
81cd51cc66 Merge pull request #6570 from btcpayserver/fix-get-store-payment
Fix: Incorrect enabled value for v1/stores/{storeId}/payment-methods/{paymentMethod}
2025-01-21 23:52:18 +09:00
d11n
20e8db7307 App: Allow receipt to be shown in iframe (#6574)
Also detects if the checkout page is shown within an iframe and hides the back to store link in that case.
2025-01-21 23:50:27 +09:00
nicolas.dorier
8e927eee73 Better validation of inputs when setting on-chain payment method by API 2025-01-21 23:37:56 +09:00
nicolas.dorier
bbe95d780f Fix: Incorrect enabled value for v1/stores/{storeId}/payment-methods/{paymentMethod} 2025-01-21 17:48:37 +09:00
Nicolas Dorier
01250f6aee Add ability to move a payout from InProgress to AwaitingPayment (#6564) 2025-01-21 15:37:45 +09:00