From efe1686c05b6ce95d475d7495f6cc2b954e20200 Mon Sep 17 00:00:00 2001
From: Umar Bolatov <bolatovumar@gmail.com>
Date: Wed, 6 Jul 2022 18:38:51 -0700
Subject: [PATCH] Don't show "Set up a Lightning node" when LN is not supported
 (#3935)

See discussion here: https://github.com/btcpayserver/btcpayserver/discussions/3868
---
 .../UIStoresController.Dashboard.cs           |  4 ++-
 .../StoreDashboardViewModel.cs                |  1 +
 .../LNURL/LightningAddressOption.cshtml       |  5 +++
 BTCPayServer/Views/UIStores/Dashboard.cshtml  | 36 ++++++++++---------
 4 files changed, 28 insertions(+), 18 deletions(-)

diff --git a/BTCPayServer/Controllers/UIStoresController.Dashboard.cs b/BTCPayServer/Controllers/UIStoresController.Dashboard.cs
index 5e80e0ddd..3a78ac538 100644
--- a/BTCPayServer/Controllers/UIStoresController.Dashboard.cs
+++ b/BTCPayServer/Controllers/UIStoresController.Dashboard.cs
@@ -24,13 +24,15 @@ namespace BTCPayServer.Controllers
 
             var walletEnabled = derivationSchemes.Any(scheme => !string.IsNullOrEmpty(scheme.Value) && scheme.Enabled);
             var lightningEnabled = lightningNodes.Any(ln => !string.IsNullOrEmpty(ln.Address) && ln.Enabled);
+            var cryptoCode = _NetworkProvider.DefaultNetwork.CryptoCode;
             var vm = new StoreDashboardViewModel
             {
                 WalletEnabled = walletEnabled,
                 LightningEnabled = lightningEnabled,
+                LightningSupported = _NetworkProvider.GetNetwork<BTCPayNetwork>(cryptoCode).SupportLightning,
                 StoreId = CurrentStore.Id,
                 StoreName = CurrentStore.StoreName,
-                CryptoCode = _NetworkProvider.DefaultNetwork.CryptoCode,
+                CryptoCode = cryptoCode,
                 IsSetUp = walletEnabled || lightningEnabled
             };
             
diff --git a/BTCPayServer/Models/StoreViewModels/StoreDashboardViewModel.cs b/BTCPayServer/Models/StoreViewModels/StoreDashboardViewModel.cs
index 4df990c60..a7bf1b86f 100644
--- a/BTCPayServer/Models/StoreViewModels/StoreDashboardViewModel.cs
+++ b/BTCPayServer/Models/StoreViewModels/StoreDashboardViewModel.cs
@@ -10,6 +10,7 @@ public class StoreDashboardViewModel
     public string StoreName { get; set; }
     public bool WalletEnabled { get; set; }
     public bool LightningEnabled { get; set; }
+    public bool LightningSupported { get; set; }
     public bool IsSetUp { get; set; }
     public List<AppData> Apps { get; set; } = new();
 }
diff --git a/BTCPayServer/Views/Shared/LNURL/LightningAddressOption.cshtml b/BTCPayServer/Views/Shared/LNURL/LightningAddressOption.cshtml
index 0ed2a7f78..3218afee1 100644
--- a/BTCPayServer/Views/Shared/LNURL/LightningAddressOption.cshtml
+++ b/BTCPayServer/Views/Shared/LNURL/LightningAddressOption.cshtml
@@ -9,7 +9,10 @@
         isLightningEnabled &&
         isLNUrlEnabled &&
         store.GetSupportedPaymentMethods(BTCPayNetworkProvider).OfType<LNURLPaySupportedPaymentMethod>().Any(type => type.CryptoCode == cryptoCode);
+    var network = BTCPayNetworkProvider.GetNetwork<BTCPayNetwork>(cryptoCode);
 }
+
+@if (network.SupportLightning) {
 <li class="list-group-item bg-tile" id="lightning-address-option">
     <div class="d-flex align-items-center">
         <span class="d-flex flex-wrap flex-fill flex-column flex-sm-row">
@@ -48,3 +51,5 @@
         </span>
     </div>
 </li>
+}
+
diff --git a/BTCPayServer/Views/UIStores/Dashboard.cshtml b/BTCPayServer/Views/UIStores/Dashboard.cshtml
index 65c6ea516..bcfb9b956 100644
--- a/BTCPayServer/Views/UIStores/Dashboard.cshtml
+++ b/BTCPayServer/Views/UIStores/Dashboard.cshtml
@@ -162,24 +162,26 @@ else
                 </div>
             </div>
         }
-        @if (!Model.LightningEnabled)
-        {
-            <a asp-controller="UIStores" asp-action="SetupLightningNode" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" id="SetupGuide-Lightning" class="list-group-item list-group-item-action d-flex align-items-center order-1">
-                <vc:icon symbol="new-wallet"/>
-                <div class="content">
-                    <h5 class="mb-0">Set up a Lightning node</h5>
+        @if (Model.LightningSupported) {
+            if (!Model.LightningEnabled)
+            {
+                <a asp-controller="UIStores" asp-action="SetupLightningNode" asp-route-storeId="@Model.StoreId" asp-route-cryptoCode="@Model.CryptoCode" id="SetupGuide-Lightning" class="list-group-item list-group-item-action d-flex align-items-center order-1">
+                    <vc:icon symbol="new-wallet"/>
+                    <div class="content">
+                        <h5 class="mb-0">Set up a Lightning node</h5>
+                    </div>
+                    <vc:icon symbol="caret-right"/>
+                </a>
+            }
+            else
+            {
+                <div class="list-group-item d-flex align-items-center" id="SetupGuide-LightningDone">
+                    <vc:icon symbol="done"/>
+                    <div class="content">
+                        <h5 class="mb-0 text-success">Set up a Lightning node</h5>
+                    </div>
                 </div>
-                <vc:icon symbol="caret-right"/>
-            </a>
-        }
-        else
-        {
-            <div class="list-group-item d-flex align-items-center" id="SetupGuide-LightningDone">
-                <vc:icon symbol="done"/>
-                <div class="content">
-                    <h5 class="mb-0 text-success">Set up a Lightning node</h5>
-                </div>
-            </div>
+            }
         }
     </div>
 }