From b47b942e97e9cc4da9f4ebcaa6e5334997433cdd Mon Sep 17 00:00:00 2001 From: Dennis Reimann Date: Mon, 3 Aug 2020 10:12:21 +0200 Subject: [PATCH] Wallet UI: Improve views (#1763) * Improve UpdateStore and DerivationScheme views fix * Improve wallet views CSS fix * Apply suggestions from code review Co-authored-by: Andrew Camilleri --- .../DerivationSchemeViewModel.cs | 4 +- .../WalletViewModels/RescanWalletModel.cs | 4 + .../WalletViewModels/WalletPSBTViewModel.cs | 1 + .../WalletSettingsViewModel.cs | 5 + .../Views/Stores/AddDerivationScheme.cshtml | 86 ++++++------ ...vationSchemes_HardwareWalletDialogs.cshtml | 44 +++++-- ...DerivationSchemes_NBXWalletGenerate.cshtml | 21 +-- .../Views/Wallets/CoinSelection.cshtml | 8 +- .../Views/Wallets/NewPullPayment.cshtml | 22 ++-- BTCPayServer/Views/Wallets/Payouts.cshtml | 122 +++++++++--------- BTCPayServer/Views/Wallets/WalletPSBT.cshtml | 4 +- .../Views/Wallets/WalletReceive.cshtml | 24 ++-- .../Views/Wallets/WalletRescan.cshtml | 15 +-- BTCPayServer/Views/Wallets/WalletSend.cshtml | 68 +++++----- .../Views/Wallets/WalletSettings.cshtml | 55 ++++---- 15 files changed, 259 insertions(+), 224 deletions(-) diff --git a/BTCPayServer/Models/StoreViewModels/DerivationSchemeViewModel.cs b/BTCPayServer/Models/StoreViewModels/DerivationSchemeViewModel.cs index 9d7215dd0..21372d30a 100644 --- a/BTCPayServer/Models/StoreViewModels/DerivationSchemeViewModel.cs +++ b/BTCPayServer/Models/StoreViewModels/DerivationSchemeViewModel.cs @@ -11,6 +11,8 @@ namespace BTCPayServer.Models.StoreViewModels public DerivationSchemeViewModel() { } + + [Display(Name = "Derivation scheme")] public string DerivationScheme { get; set; @@ -31,7 +33,7 @@ namespace BTCPayServer.Models.StoreViewModels public KeyPath RootKeyPath { get; set; } - [Display(Name = "Electrum/Hardware Wallet File")] + [Display(Name = "Wallet File")] public IFormFile WalletFile { get; set; } public string Config { get; set; } public string Source { get; set; } diff --git a/BTCPayServer/Models/WalletViewModels/RescanWalletModel.cs b/BTCPayServer/Models/WalletViewModels/RescanWalletModel.cs index ee8e9b408..bd70c8e6b 100644 --- a/BTCPayServer/Models/WalletViewModels/RescanWalletModel.cs +++ b/BTCPayServer/Models/WalletViewModels/RescanWalletModel.cs @@ -1,4 +1,5 @@ using System; +using System.ComponentModel; using System.ComponentModel.DataAnnotations; using NBXplorer.Models; @@ -12,11 +13,14 @@ namespace BTCPayServer.Models.WalletViewModels public bool Ok => IsServerAdmin && IsSupportedByCurrency && IsFullySync; [Range(1000, 10_000)] + [DisplayName("Batch size")] public int BatchSize { get; set; } = 3000; [Range(0, 10_000_000)] + [DisplayName("Starting index")] public int StartingIndex { get; set; } = 0; [Range(100, 100000)] + [DisplayName("Gap limit")] public int GapLimit { get; set; } = 10000; public int? Progress { get; set; } diff --git a/BTCPayServer/Models/WalletViewModels/WalletPSBTViewModel.cs b/BTCPayServer/Models/WalletViewModels/WalletPSBTViewModel.cs index 2d21a1534..44f857528 100644 --- a/BTCPayServer/Models/WalletViewModels/WalletPSBTViewModel.cs +++ b/BTCPayServer/Models/WalletViewModels/WalletPSBTViewModel.cs @@ -26,6 +26,7 @@ namespace BTCPayServer.Models.WalletViewModels _FileName = value; } } + [Display(Name = "PSBT content")] public string PSBT { get; set; } public List Errors { get; set; } = new List(); diff --git a/BTCPayServer/Models/WalletViewModels/WalletSettingsViewModel.cs b/BTCPayServer/Models/WalletViewModels/WalletSettingsViewModel.cs index b537b8710..28c9be42a 100644 --- a/BTCPayServer/Models/WalletViewModels/WalletSettingsViewModel.cs +++ b/BTCPayServer/Models/WalletViewModels/WalletSettingsViewModel.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using System.ComponentModel; using System.ComponentModel.DataAnnotations; namespace BTCPayServer.Models.WalletViewModels @@ -6,6 +7,7 @@ namespace BTCPayServer.Models.WalletViewModels public class WalletSettingsViewModel { public string Label { get; set; } + [DisplayName("Derivation scheme")] public string DerivationScheme { get; set; } public string DerivationSchemeInput { get; set; } [Display(Name = "Is signing key")] @@ -20,9 +22,12 @@ namespace BTCPayServer.Models.WalletViewModels public class WalletSettingsAccountKeyViewModel { + [DisplayName("Account key")] public string AccountKey { get; set; } + [DisplayName("Master fingerprint")] [Validation.HDFingerPrintValidator] public string MasterFingerprint { get; set; } + [DisplayName("Account key path")] [Validation.KeyPathValidator] public string AccountKeyPath { get; set; } } diff --git a/BTCPayServer/Views/Stores/AddDerivationScheme.cshtml b/BTCPayServer/Views/Stores/AddDerivationScheme.cshtml index d91a382eb..c059a5282 100644 --- a/BTCPayServer/Views/Stores/AddDerivationScheme.cshtml +++ b/BTCPayServer/Views/Stores/AddDerivationScheme.cshtml @@ -24,10 +24,10 @@ } - +
@@ -60,7 +60,7 @@
} -
@@ -72,12 +72,15 @@
-
Derivation Scheme
- The DerivationScheme represents the destination of the funds received by your invoice. It is generated by your wallet software. Please, verify that you are generating the right addresses by clicking on 'Check ExtPubKey' +
Derivation scheme
+

+ The derivation scheme represents the destination of the funds received by your invoice. + It is generated by your wallet software. +

- +
-
- BTCPay format memo - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Address typeExample
P2WPKHxpub...
P2SH-P2WPKHxpub...-[p2sh]
P2PKHxpub...-[legacy]
Multi-sig P2WSH2-of-xpub1...-xpub2...
Multi-sig P2SH-P2WSH2-of-xpub1...-xpub2...-[p2sh]
Multi-sig P2SH2-of-xpub1...-xpub2...-[legacy]
-
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Address typeExample
P2WPKHxpub...
P2SH-P2WPKHxpub...-[p2sh]
P2PKHxpub...-[legacy]
Multi-sig P2WSH2-of-xpub1...-xpub2...
Multi-sig P2SH-P2WSH2-of-xpub1...-xpub2...-[p2sh]
Multi-sig P2SH2-of-xpub1...-xpub2...-[legacy]
Additional pairing information
diff --git a/BTCPayServer/Views/Stores/AddDerivationSchemes_HardwareWalletDialogs.cshtml b/BTCPayServer/Views/Stores/AddDerivationSchemes_HardwareWalletDialogs.cshtml index bd636dfa8..c70f6f5f7 100644 --- a/BTCPayServer/Views/Stores/AddDerivationSchemes_HardwareWalletDialogs.cshtml +++ b/BTCPayServer/Views/Stores/AddDerivationSchemes_HardwareWalletDialogs.cshtml @@ -9,7 +9,7 @@ diff --git a/BTCPayServer/Views/Stores/AddDerivationSchemes_NBXWalletGenerate.cshtml b/BTCPayServer/Views/Stores/AddDerivationSchemes_NBXWalletGenerate.cshtml index 67970e53e..e245b75bf 100644 --- a/BTCPayServer/Views/Stores/AddDerivationSchemes_NBXWalletGenerate.cshtml +++ b/BTCPayServer/Views/Stores/AddDerivationSchemes_NBXWalletGenerate.cshtml @@ -2,7 +2,7 @@ @model NBXplorer.Models.GenerateWalletRequest