From b31f1812d2fd04cf45c36e16e71467026c628462 Mon Sep 17 00:00:00 2001 From: d11n Date: Thu, 30 Nov 2023 10:05:35 +0100 Subject: [PATCH] Greenfield: Remove unused checkout type setting from POS (#5512) Cam across this while browsing the API docs: The checkout type setting isn't used for the POS, so we should simply remove it as this is configured on the store-level. --- BTCPayServer.Client/Models/CreateAppRequest.cs | 1 - .../Controllers/GreenField/GreenfieldAppsController.cs | 3 +-- BTCPayServer/Services/Apps/PointOfSaleSettings.cs | 1 - BTCPayServer/wwwroot/swagger/v1/swagger.template.apps.json | 3 --- 4 files changed, 1 insertion(+), 7 deletions(-) diff --git a/BTCPayServer.Client/Models/CreateAppRequest.cs b/BTCPayServer.Client/Models/CreateAppRequest.cs index bdb1a62d7..68efcb675 100644 --- a/BTCPayServer.Client/Models/CreateAppRequest.cs +++ b/BTCPayServer.Client/Models/CreateAppRequest.cs @@ -42,7 +42,6 @@ namespace BTCPayServer.Client.Models public bool? Archived { get; set; } = null; public string FormId { get; set; } = null; public string EmbeddedCSS { get; set; } = null; - public CheckoutType? CheckoutType { get; set; } = null; } public enum CrowdfundResetEvery diff --git a/BTCPayServer/Controllers/GreenField/GreenfieldAppsController.cs b/BTCPayServer/Controllers/GreenField/GreenfieldAppsController.cs index db60ef1eb..fb6a796f3 100644 --- a/BTCPayServer/Controllers/GreenField/GreenfieldAppsController.cs +++ b/BTCPayServer/Controllers/GreenField/GreenfieldAppsController.cs @@ -291,8 +291,7 @@ namespace BTCPayServer.Controllers.Greenfield EmbeddedCSS = request.EmbeddedCSS, RedirectAutomatically = request.RedirectAutomatically, RequiresRefundEmail = BoolToRequiresRefundEmail(request.RequiresRefundEmail) ?? RequiresRefundEmail.InheritFromStore, - FormId = request.FormId, - CheckoutType = request.CheckoutType ?? CheckoutType.V1 + FormId = request.FormId }; } diff --git a/BTCPayServer/Services/Apps/PointOfSaleSettings.cs b/BTCPayServer/Services/Apps/PointOfSaleSettings.cs index 397d25007..163636af9 100644 --- a/BTCPayServer/Services/Apps/PointOfSaleSettings.cs +++ b/BTCPayServer/Services/Apps/PointOfSaleSettings.cs @@ -113,6 +113,5 @@ namespace BTCPayServer.Services.Apps public string NotificationUrl { get; set; } public string RedirectUrl { get; set; } public bool? RedirectAutomatically { get; set; } - public CheckoutType CheckoutType { get; internal set; } } } diff --git a/BTCPayServer/wwwroot/swagger/v1/swagger.template.apps.json b/BTCPayServer/wwwroot/swagger/v1/swagger.template.apps.json index 82ede0e4c..2114486b2 100644 --- a/BTCPayServer/wwwroot/swagger/v1/swagger.template.apps.json +++ b/BTCPayServer/wwwroot/swagger/v1/swagger.template.apps.json @@ -903,9 +903,6 @@ "description": "Whether refund email is required when paying the invoice. Defaults to what is set in the store settings", "nullable": true }, - "checkoutType": { - "$ref": "#/components/schemas/CheckoutType" - }, "formId": { "type": "string", "description": "Form ID to request customer data",