From a9fbba5825a35c2f0412701b273bb43e405a03af Mon Sep 17 00:00:00 2001 From: Dennis Reimann Date: Tue, 11 Mar 2025 10:54:17 +0100 Subject: [PATCH] UI: Fix and unify localizer usage for page titles Issue was caused by duplicate translation through a combination of `StringLocalizer` and `text-translate="true"` usage. Fixes #6622. --- BTCPayServer/Components/StoreNumbers/Default.cshtml | 2 +- BTCPayServer/Views/Shared/CreateOrEditRole.cshtml | 9 ++++----- .../Views/Shared/Crowdfund/UpdateCrowdfund.cshtml | 2 +- BTCPayServer/Views/Shared/ListRoles.cshtml | 4 ++-- BTCPayServer/Views/Shared/PayButton/Enable.cshtml | 5 ++--- BTCPayServer/Views/Shared/PayButton/PayButton.cshtml | 5 ++--- .../Views/Shared/PointOfSale/UpdatePointOfSale.cshtml | 2 +- BTCPayServer/Views/UIAccount/CheatPermissions.cshtml | 4 ++-- BTCPayServer/Views/UIAccount/SignedOut.cshtml | 4 ++-- BTCPayServer/Views/UIApps/CreateApp.cshtml | 4 ++-- BTCPayServer/Views/UIFido2/Create.cshtml | 2 +- BTCPayServer/Views/UIForms/FormsList.cshtml | 2 +- BTCPayServer/Views/UIForms/Modify.cshtml | 2 +- BTCPayServer/Views/UIInvoice/CreateInvoice.cshtml | 4 ++-- BTCPayServer/Views/UIInvoice/Invoice.cshtml | 4 ++-- BTCPayServer/Views/UIInvoice/ListInvoices.cshtml | 2 +- BTCPayServer/Views/UILNURL/EditLightningAddress.cshtml | 2 +- BTCPayServer/Views/UILNURLAuth/Create.cshtml | 2 +- .../Configure.cshtml | 2 +- .../UILightningLikePayout/ConfirmLightningPayout.cshtml | 4 ++-- .../UILightningLikePayout/LightningPayoutResult.cshtml | 5 ++--- BTCPayServer/Views/UIManage/APIKeys.cshtml | 2 +- BTCPayServer/Views/UIManage/AddApiKey.cshtml | 6 +++--- BTCPayServer/Views/UIManage/ChangePassword.cshtml | 2 +- BTCPayServer/Views/UIManage/EnableAuthenticator.cshtml | 4 ++-- BTCPayServer/Views/UIManage/GenerateRecoveryCodes.cshtml | 2 +- BTCPayServer/Views/UIManage/Index.cshtml | 2 +- BTCPayServer/Views/UIManage/LoginCodes.cshtml | 2 +- BTCPayServer/Views/UIManage/NotificationSettings.cshtml | 4 ++-- BTCPayServer/Views/UIManage/SetPassword.cshtml | 2 +- .../Views/UIManage/TwoFactorAuthentication.cshtml | 2 +- BTCPayServer/Views/UINotifications/Index.cshtml | 2 +- .../UIOnChainAutomatedPayoutProcessors/Configure.cshtml | 4 ++-- .../Views/UIPaymentRequest/EditPaymentRequest.cshtml | 2 +- .../ConfigureStorePayoutProcessors.cshtml | 2 +- BTCPayServer/Views/UIPullPayment/EditPullPayment.cshtml | 4 ++-- BTCPayServer/Views/UIServer/Branding.cshtml | 2 +- .../Views/UIServer/CLightningRestServices.cshtml | 2 +- BTCPayServer/Views/UIServer/ConfiguratorService.cshtml | 4 ++-- BTCPayServer/Views/UIServer/CreateDictionary.cshtml | 4 ++-- .../Views/UIServer/CreateTemporaryFileUrl.cshtml | 2 +- BTCPayServer/Views/UIServer/CreateUser.cshtml | 4 ++-- BTCPayServer/Views/UIServer/DynamicDnsServices.cshtml | 4 ++-- .../Views/UIServer/EditAmazonS3StorageProvider.cshtml | 2 +- .../UIServer/EditAzureBlobStorageStorageProvider.cshtml | 2 +- BTCPayServer/Views/UIServer/EditDictionary.cshtml | 1 - .../Views/UIServer/EditFileSystemStorageProvider.cshtml | 2 +- .../EditGoogleCloudStorageStorageProvider.cshtml | 2 +- BTCPayServer/Views/UIServer/Emails.cshtml | 2 +- BTCPayServer/Views/UIServer/Files.cshtml | 2 +- .../Views/UIServer/LightningChargeServices.cshtml | 4 ++-- BTCPayServer/Views/UIServer/ListDictionaries.cshtml | 4 ++-- BTCPayServer/Views/UIServer/ListStores.cshtml | 2 +- BTCPayServer/Views/UIServer/ListUsers.cshtml | 2 +- BTCPayServer/Views/UIServer/LndSeedBackup.cshtml | 4 ++-- BTCPayServer/Views/UIServer/LndServices.cshtml | 4 ++-- BTCPayServer/Views/UIServer/Logs.cshtml | 2 +- BTCPayServer/Views/UIServer/Maintenance.cshtml | 2 +- BTCPayServer/Views/UIServer/Policies.cshtml | 4 ++-- BTCPayServer/Views/UIServer/ResetUserPassword.cshtml | 6 +++--- BTCPayServer/Views/UIServer/SSHService.cshtml | 4 ++-- BTCPayServer/Views/UIServer/Services.cshtml | 2 +- BTCPayServer/Views/UIServer/Storage.cshtml | 4 ++-- BTCPayServer/Views/UIServer/User.cshtml | 2 +- .../Views/UIStorePullPayments/NewPullPayment.cshtml | 4 ++-- BTCPayServer/Views/UIStores/CheckoutAppearance.cshtml | 2 +- BTCPayServer/Views/UIStores/CreateToken.cshtml | 6 +++--- BTCPayServer/Views/UIStores/Lightning.cshtml | 2 +- BTCPayServer/Views/UIStores/LightningSettings.cshtml | 2 +- BTCPayServer/Views/UIStores/ListTokens.cshtml | 2 +- BTCPayServer/Views/UIStores/ModifyWebhook.cshtml | 2 +- BTCPayServer/Views/UIStores/Rates.cshtml | 2 +- BTCPayServer/Views/UIStores/RequestPairing.cshtml | 4 ++-- BTCPayServer/Views/UIStores/StoreEmails.cshtml | 4 ++-- BTCPayServer/Views/UIStores/StoreUsers.cshtml | 2 +- BTCPayServer/Views/UIStores/TestWebhook.cshtml | 2 +- BTCPayServer/Views/UIStores/WalletSettings.cshtml | 2 +- BTCPayServer/Views/UIStores/Webhooks.cshtml | 2 +- BTCPayServer/Views/UIUserStores/CreateStore.cshtml | 2 +- BTCPayServer/Views/UIUserStores/ListStores.cshtml | 2 +- BTCPayServer/Views/UIWallets/WalletLabels.cshtml | 2 +- BTCPayServer/Views/UIWallets/WalletPSBTCombine.cshtml | 2 +- BTCPayServer/Views/UIWallets/WalletPSBTDecoded.cshtml | 2 +- 83 files changed, 119 insertions(+), 124 deletions(-) diff --git a/BTCPayServer/Components/StoreNumbers/Default.cshtml b/BTCPayServer/Components/StoreNumbers/Default.cshtml index b9517b47d..9511a07d0 100644 --- a/BTCPayServer/Components/StoreNumbers/Default.cshtml +++ b/BTCPayServer/Components/StoreNumbers/Default.cshtml @@ -24,7 +24,7 @@ {
-
@ViewLocalizer["Paid invoices in the last {0} days", Model.TimeframeDays]
+
@ViewLocalizer["Paid invoices in the last {0} days", Model.TimeframeDays]
@if (Model.PaidInvoices > 0) { View All diff --git a/BTCPayServer/Views/Shared/CreateOrEditRole.cshtml b/BTCPayServer/Views/Shared/CreateOrEditRole.cshtml index 0f6db3857..5f248ba84 100644 --- a/BTCPayServer/Views/Shared/CreateOrEditRole.cshtml +++ b/BTCPayServer/Views/Shared/CreateOrEditRole.cshtml @@ -12,12 +12,11 @@ role = null; var storeId = Context.GetRouteValue("storeId") as string; + var title = role is null ? StringLocalizer["Create role"] : StringLocalizer["Update Role"]; if (storeId is null) - ViewData.SetActivePage(ServerNavPages.Roles, role is null ? "Create role" : "Update Role"); + ViewData.SetActivePage(ServerNavPages.Roles, title); else - { - ViewData.SetActivePage(StoreNavPages.Roles, role is null ? "Create role" : "Update Role"); - } + ViewData.SetActivePage(StoreNavPages.Roles, title, storeId); var storePolicies = Policies.AllPolicies.Where(Policies.IsStorePolicy).ToArray(); } @@ -30,7 +29,7 @@ -

@ViewData["Title"]

+

@ViewData["Title"]

diff --git a/BTCPayServer/Views/Shared/Crowdfund/UpdateCrowdfund.cshtml b/BTCPayServer/Views/Shared/Crowdfund/UpdateCrowdfund.cshtml index e4566b26d..914cd0c3a 100644 --- a/BTCPayServer/Views/Shared/Crowdfund/UpdateCrowdfund.cshtml +++ b/BTCPayServer/Views/Shared/Crowdfund/UpdateCrowdfund.cshtml @@ -30,7 +30,7 @@
diff --git a/BTCPayServer/Views/UIServer/Services.cshtml b/BTCPayServer/Views/UIServer/Services.cshtml index 068adc18c..91a1c600d 100644 --- a/BTCPayServer/Views/UIServer/Services.cshtml +++ b/BTCPayServer/Views/UIServer/Services.cshtml @@ -4,7 +4,7 @@ } diff --git a/BTCPayServer/Views/UIServer/Storage.cshtml b/BTCPayServer/Views/UIServer/Storage.cshtml index 58c0fa182..0c58af783 100644 --- a/BTCPayServer/Views/UIServer/Storage.cshtml +++ b/BTCPayServer/Views/UIServer/Storage.cshtml @@ -10,9 +10,9 @@ - + -

@ViewData["Title"]

+

@ViewData["Title"]

diff --git a/BTCPayServer/Views/UIServer/User.cshtml b/BTCPayServer/Views/UIServer/User.cshtml index ae7acc072..d78ca8fc2 100644 --- a/BTCPayServer/Views/UIServer/User.cshtml +++ b/BTCPayServer/Views/UIServer/User.cshtml @@ -16,7 +16,7 @@ -

@ViewData["Title"]

+

@ViewData["Title"]

diff --git a/BTCPayServer/Views/UIStorePullPayments/NewPullPayment.cshtml b/BTCPayServer/Views/UIStorePullPayments/NewPullPayment.cshtml index 3f94f6400..18ea3aa4b 100644 --- a/BTCPayServer/Views/UIStorePullPayments/NewPullPayment.cshtml +++ b/BTCPayServer/Views/UIStorePullPayments/NewPullPayment.cshtml @@ -22,9 +22,9 @@ - + -

@ViewData["Title"]

+

@ViewData["Title"]

diff --git a/BTCPayServer/Views/UIStores/CheckoutAppearance.cshtml b/BTCPayServer/Views/UIStores/CheckoutAppearance.cshtml index 83dbe9521..4dd83ee19 100644 --- a/BTCPayServer/Views/UIStores/CheckoutAppearance.cshtml +++ b/BTCPayServer/Views/UIStores/CheckoutAppearance.cshtml @@ -66,7 +66,7 @@ diff --git a/BTCPayServer/Views/UIStores/CreateToken.cshtml b/BTCPayServer/Views/UIStores/CreateToken.cshtml index a8ee48324..fa4b26c1d 100644 --- a/BTCPayServer/Views/UIStores/CreateToken.cshtml +++ b/BTCPayServer/Views/UIStores/CreateToken.cshtml @@ -15,14 +15,14 @@ - + -

@ViewData["Title"]

+

@ViewData["Title"]

} else { -

@ViewData["Title"]

+

@ViewData["Title"]

} diff --git a/BTCPayServer/Views/UIStores/Lightning.cshtml b/BTCPayServer/Views/UIStores/Lightning.cshtml index 272d3f079..ca05e0bdc 100644 --- a/BTCPayServer/Views/UIStores/Lightning.cshtml +++ b/BTCPayServer/Views/UIStores/Lightning.cshtml @@ -7,7 +7,7 @@ ViewData.SetActivePage(StoreNavPages.Lightning, StringLocalizer["{0} Lightning", Model.CryptoCode], $"{Context.GetStoreData().Id}-{Model.CryptoCode}"); } -

@ViewData["Title"]

+

@ViewData["Title"]

diff --git a/BTCPayServer/Views/UIStores/LightningSettings.cshtml b/BTCPayServer/Views/UIStores/LightningSettings.cshtml index c4c87444c..af546ffdc 100644 --- a/BTCPayServer/Views/UIStores/LightningSettings.cshtml +++ b/BTCPayServer/Views/UIStores/LightningSettings.cshtml @@ -8,7 +8,7 @@ diff --git a/BTCPayServer/Views/UIStores/ListTokens.cshtml b/BTCPayServer/Views/UIStores/ListTokens.cshtml index 2bb856b52..87a86704d 100644 --- a/BTCPayServer/Views/UIStores/ListTokens.cshtml +++ b/BTCPayServer/Views/UIStores/ListTokens.cshtml @@ -34,7 +34,7 @@

-

@ViewData["Title"]

+

@ViewData["Title"]

Create Token diff --git a/BTCPayServer/Views/UIStores/ModifyWebhook.cshtml b/BTCPayServer/Views/UIStores/ModifyWebhook.cshtml index d580d06db..15c85abd3 100644 --- a/BTCPayServer/Views/UIStores/ModifyWebhook.cshtml +++ b/BTCPayServer/Views/UIStores/ModifyWebhook.cshtml @@ -22,7 +22,7 @@ -

@ViewData["Title"]

+

@ViewData["Title"]

@if (Model.IsNew) { diff --git a/BTCPayServer/Views/UIStores/Rates.cshtml b/BTCPayServer/Views/UIStores/Rates.cshtml index c48ef0f96..9a9b0fbd4 100644 --- a/BTCPayServer/Views/UIStores/Rates.cshtml +++ b/BTCPayServer/Views/UIStores/Rates.cshtml @@ -9,7 +9,7 @@ diff --git a/BTCPayServer/Views/UIStores/RequestPairing.cshtml b/BTCPayServer/Views/UIStores/RequestPairing.cshtml index 9db8bef28..47c979103 100644 --- a/BTCPayServer/Views/UIStores/RequestPairing.cshtml +++ b/BTCPayServer/Views/UIStores/RequestPairing.cshtml @@ -30,12 +30,12 @@ -

@ViewData["Title"]

+

@ViewData["Title"]

} else { -

@ViewData["Title"]

+

@ViewData["Title"]

}
diff --git a/BTCPayServer/Views/UIStores/StoreEmails.cshtml b/BTCPayServer/Views/UIStores/StoreEmails.cshtml index fb6036d0f..99e96577c 100644 --- a/BTCPayServer/Views/UIStores/StoreEmails.cshtml +++ b/BTCPayServer/Views/UIStores/StoreEmails.cshtml @@ -21,9 +21,9 @@ - + -

@ViewData["Title"]

+

@ViewData["Title"]

@if (Model.Rules.Any()) diff --git a/BTCPayServer/Views/UIStores/StoreUsers.cshtml b/BTCPayServer/Views/UIStores/StoreUsers.cshtml index 39c8b8052..1ce4f8262 100644 --- a/BTCPayServer/Views/UIStores/StoreUsers.cshtml +++ b/BTCPayServer/Views/UIStores/StoreUsers.cshtml @@ -19,7 +19,7 @@ } } -

@ViewData["Title"]

+

@ViewData["Title"]

diff --git a/BTCPayServer/Views/UIStores/TestWebhook.cshtml b/BTCPayServer/Views/UIStores/TestWebhook.cshtml index fa2cd665b..5e1ab4ce9 100644 --- a/BTCPayServer/Views/UIStores/TestWebhook.cshtml +++ b/BTCPayServer/Views/UIStores/TestWebhook.cshtml @@ -6,7 +6,7 @@ } diff --git a/BTCPayServer/Views/UIStores/WalletSettings.cshtml b/BTCPayServer/Views/UIStores/WalletSettings.cshtml index bdc7e02d5..7be22f01e 100644 --- a/BTCPayServer/Views/UIStores/WalletSettings.cshtml +++ b/BTCPayServer/Views/UIStores/WalletSettings.cshtml @@ -18,7 +18,7 @@ }