Fix statusMessage handling for the Receive wallet page

This commit is contained in:
nicolas.dorier
2020-01-18 15:32:01 +09:00
parent 025da0261d
commit a2be7ee471
2 changed files with 48 additions and 46 deletions

View File

@@ -307,7 +307,7 @@ namespace BTCPayServer.Controllers
[HttpGet] [HttpGet]
[Route("{walletId}/receive")] [Route("{walletId}/receive")]
public IActionResult WalletReceive([ModelBinder(typeof(WalletIdModelBinder))] public IActionResult WalletReceive([ModelBinder(typeof(WalletIdModelBinder))]
WalletId walletId, string statusMessage = null) WalletId walletId)
{ {
if (walletId?.StoreId == null) if (walletId?.StoreId == null)
return NotFound(); return NotFound();
@@ -319,11 +319,6 @@ namespace BTCPayServer.Controllers
return NotFound(); return NotFound();
var address = _WalletReceiveStateService.Get(walletId)?.Address; var address = _WalletReceiveStateService.Get(walletId)?.Address;
if (!string.IsNullOrEmpty(statusMessage))
{
TempData[WellKnownTempData.SuccessMessage] = statusMessage;
}
return View(new WalletReceiveViewModel() return View(new WalletReceiveViewModel()
{ {
CryptoCode = walletId.CryptoCode, CryptoCode = walletId.CryptoCode,
@@ -345,7 +340,6 @@ namespace BTCPayServer.Controllers
var network = this.NetworkProvider.GetNetwork<BTCPayNetwork>(walletId?.CryptoCode); var network = this.NetworkProvider.GetNetwork<BTCPayNetwork>(walletId?.CryptoCode);
if (network == null) if (network == null)
return NotFound(); return NotFound();
var statusMessage = string.Empty;
var wallet = _walletProvider.GetWallet(network); var wallet = _walletProvider.GetWallet(network);
switch (command) switch (command)
{ {
@@ -358,12 +352,12 @@ namespace BTCPayServer.Controllers
var address = cachedAddress.ScriptPubKey.GetDestinationAddress(network.NBitcoinNetwork); var address = cachedAddress.ScriptPubKey.GetDestinationAddress(network.NBitcoinNetwork);
ExplorerClientProvider.GetExplorerClient(network) ExplorerClientProvider.GetExplorerClient(network)
.CancelReservation(cachedAddress.DerivationStrategy, new[] {cachedAddress.KeyPath}); .CancelReservation(cachedAddress.DerivationStrategy, new[] {cachedAddress.KeyPath});
statusMessage = new StatusMessageModel() this.TempData.SetStatusMessageModel(new StatusMessageModel()
{ {
AllowDismiss = true, AllowDismiss = true,
Message = $"Address {address} was unreserved.", Message = $"Address {address} was unreserved.",
Severity = StatusMessageModel.StatusSeverity.Success, Severity = StatusMessageModel.StatusSeverity.Success,
}.ToString(); });
_WalletReceiveStateService.Remove(walletId); _WalletReceiveStateService.Remove(walletId);
break; break;
case "generate-new-address": case "generate-new-address":
@@ -371,7 +365,7 @@ namespace BTCPayServer.Controllers
_WalletReceiveStateService.Set(walletId, reserve); _WalletReceiveStateService.Set(walletId, reserve);
break; break;
} }
return RedirectToAction(nameof(WalletReceive), new {walletId, statusMessage}); return RedirectToAction(nameof(WalletReceive), new {walletId});
} }
[HttpGet] [HttpGet]

View File

@@ -5,7 +5,14 @@
ViewData["Title"] = "Manage wallet"; ViewData["Title"] = "Manage wallet";
ViewData.SetActivePageAndTitle(WalletsNavPages.Receive); ViewData.SetActivePageAndTitle(WalletsNavPages.Receive);
} }
@if (TempData.HasStatusMessage())
{
<div class="row">
<div class="col-md-12 text-center">
<partial name="_StatusMessage" />
</div>
</div>
}
<div class="row no-gutters"> <div class="row no-gutters">
<div class="col-lg-6 mx-auto my-auto "> <div class="col-lg-6 mx-auto my-auto ">
<form method="post" asp-action="WalletReceive" class="card text-center"> <form method="post" asp-action="WalletReceive" class="card text-center">
@@ -93,6 +100,7 @@
</script> </script>
<style> <style>
.qr-icon { .qr-icon {
height: 64px; height: 64px;
width: 64px; width: 64px;