From 8530cf35358cce6c39eccb2a63b7f41c28c4ff5e Mon Sep 17 00:00:00 2001 From: "nicolas.dorier" Date: Fri, 8 Jul 2022 12:41:55 +0900 Subject: [PATCH] Make sure we do not expose lightning services if not admin --- .../StoreLightningServices/StoreLightningServices.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/BTCPayServer/Components/StoreLightningServices/StoreLightningServices.cs b/BTCPayServer/Components/StoreLightningServices/StoreLightningServices.cs index c7a3f81a0..0c2a4e456 100644 --- a/BTCPayServer/Components/StoreLightningServices/StoreLightningServices.cs +++ b/BTCPayServer/Components/StoreLightningServices/StoreLightningServices.cs @@ -37,7 +37,8 @@ public class StoreLightningServices : ViewComponent if (vm.Store == null) throw new ArgumentNullException(nameof(vm.Store)); if (vm.CryptoCode == null) throw new ArgumentNullException(nameof(vm.CryptoCode)); if (vm.LightningNodeType != LightningNodeType.Internal) return View(vm); - + if (!User.IsInRole(Roles.ServerAdmin)) return View(vm); + var services = _externalServiceOptions.Value.ExternalServices.ToList() .Where(service => ExternalServices.LightningServiceTypes.Contains(service.Type)) .Select(async service => @@ -51,7 +52,7 @@ public class StoreLightningServices : ViewComponent }; try { - model.Link = await service.GetLink(Request.GetAbsoluteUriNoPathBase(), _btcpayServerOptions.NetworkType); + model.Link = service.GetRedirectLink(Request.GetAbsoluteUriNoPathBase(), _btcpayServerOptions.NetworkType); } catch (Exception exception) {