aljaz/btcpayserver
1
0
Fork 0
mirror of https://github.com/aljazceru/btcpayserver.git synced 2025-12-19 06:54:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix other DDOS related to GetRate

Browse Source
This commit is contained in:
nicolas.dorier
2018-07-30 22:51:39 +09:00
parent 6401af00fe
commit 57bda24664
1 changed files with 16 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
BTCPayServer/Controllers/RateController.cs
View File

@@ -46,21 +46,13 @@ namespace BTCPayServer.Controllers
err.StatusCode = 404; err.StatusCode = 404;
return err; return err;
} }
var currencypairs = "";
var supportedMethods = store.GetSupportedPaymentMethods(_NetworkProvider); var supportedMethods = store.GetSupportedPaymentMethods(_NetworkProvider);
var currencyCodes = supportedMethods.Where(method => !string.IsNullOrEmpty(method.PaymentId.CryptoCode)) var currencyCodes = supportedMethods.Where(method => !string.IsNullOrEmpty(method.PaymentId.CryptoCode))
.Select(method => method.PaymentId.CryptoCode).Distinct(); .Select(method => method.PaymentId.CryptoCode).Distinct();
var currencypairs = BuildCurrencyPairs(currencyCodes, baseCurrency);
foreach (var currencyCode in currencyCodes)
{
if (!string.IsNullOrEmpty(currencypairs))
{
currencypairs += ",";
}
currencypairs += baseCurrency + "_ " + currencyCode;
}
var result = await GetRates2(currencypairs, store.Id); var result = await GetRates2(currencypairs, store.Id);
var rates = (result as JsonResult)?.Value as Rate[]; var rates = (result as JsonResult)?.Value as Rate[];
if (rates == null) if (rates == null)
@@ -118,21 +110,11 @@ namespace BTCPayServer.Controllers
if (currencyPairs == null) if (currencyPairs == null)
{ {
currencyPairs = "";
var supportedMethods = store.GetSupportedPaymentMethods(_NetworkProvider); var supportedMethods = store.GetSupportedPaymentMethods(_NetworkProvider);
var currencyCodes = supportedMethods.Select(method => method.PaymentId.CryptoCode).Distinct(); var currencyCodes = supportedMethods.Select(method => method.PaymentId.CryptoCode).Distinct();
var defaultCrypto = store.GetDefaultCrypto(_NetworkProvider); var defaultCrypto = store.GetDefaultCrypto(_NetworkProvider);
StringBuilder currencyPairsBuilder = new StringBuilder(); currencyPairs = BuildCurrencyPairs(currencyCodes, defaultCrypto);
foreach (var currencyCode in currencyCodes)
{
if (!string.IsNullOrEmpty(currencyPairs))
{
currencyPairsBuilder.Append(",");
}
currencyPairsBuilder.Append($"{defaultCrypto}_{currencyCode}");
}
currencyPairs = currencyPairsBuilder.ToString();
if (string.IsNullOrEmpty(currencyPairs)) if (string.IsNullOrEmpty(currencyPairs))
{ {
@@ -174,6 +156,19 @@ namespace BTCPayServer.Controllers
}).Where(n => n.Name != null).ToArray()); }).Where(n => n.Name != null).ToArray());
} }
private static string BuildCurrencyPairs(IEnumerable<string> currencyCodes, string baseCrypto)
{
StringBuilder currencyPairsBuilder = new StringBuilder();
bool first = true;
foreach (var currencyCode in currencyCodes)
{
if(!first)
currencyPairsBuilder.Append(",");
currencyPairsBuilder.Append($"{baseCrypto}_{currencyCode}");
}
return currencyPairsBuilder.ToString();
}
public class Rate public class Rate
{ {