From 2d21e3b26bebcd9bce4a92ee0618af375c8b8b84 Mon Sep 17 00:00:00 2001 From: rockstardev <5191402+rockstardev@users.noreply.github.com> Date: Wed, 5 Mar 2025 22:34:59 -0600 Subject: [PATCH] Final fixes --- BTCPayServer.Tests/GreenfieldAPITests.cs | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/BTCPayServer.Tests/GreenfieldAPITests.cs b/BTCPayServer.Tests/GreenfieldAPITests.cs index 94a393f43..55f23740d 100644 --- a/BTCPayServer.Tests/GreenfieldAPITests.cs +++ b/BTCPayServer.Tests/GreenfieldAPITests.cs @@ -4132,15 +4132,15 @@ namespace BTCPayServer.Tests { From = "invalid" })); - - // check that clear server email settings works - await adminClient.UpdateServerEmailSettings(new ServerEmailSettingsData()); - var clearedSettings = await adminClient.GetServerEmailSettings(); - Assert.Equal(JsonConvert.SerializeObject(new EmailSettingsData { PasswordSet = false }), JsonConvert.SerializeObject(clearedSettings)); // NOTE: This email test fails silently in EmailSender.cs#31, can't test, but leaving for the future as reminder //await adminClient.SendEmail(admin.StoreId, // new SendEmailRequest { Body = "lol", Subject = "subj", Email = "to@example.org" }); + + // check that clear server email settings works + await adminClient.UpdateServerEmailSettings(new ServerEmailSettingsData()); + var clearedSettings = await adminClient.GetServerEmailSettings(); + Assert.Equal(JsonConvert.SerializeObject(new ServerEmailSettingsData { PasswordSet = false }), JsonConvert.SerializeObject(clearedSettings)); } [Fact(Timeout = 60 * 2 * 1000)] @@ -4173,13 +4173,14 @@ namespace BTCPayServer.Tests async () => await adminClient.UpdateStoreEmailSettings(admin.StoreId, new EmailSettingsData { From = "invalid" })); + // send test email + await adminClient.SendEmail(admin.StoreId, + new SendEmailRequest { Body = "lol", Subject = "subj", Email = "to@example.org" }); + // clear store email settings await adminClient.UpdateStoreEmailSettings(admin.StoreId, new EmailSettingsData()); var clearedSettings = await adminClient.GetStoreEmailSettings(admin.StoreId); Assert.Equal(JsonConvert.SerializeObject(new EmailSettingsData { PasswordSet = false }), JsonConvert.SerializeObject(clearedSettings)); - - await adminClient.SendEmail(admin.StoreId, - new SendEmailRequest { Body = "lol", Subject = "subj", Email = "to@example.org" }); } [Fact(Timeout = 60 * 2 * 1000)]