From db7768ef57b8ea74343db6d069b802c2e3693859 Mon Sep 17 00:00:00 2001
From: Kukks <evilkukka@gmail.com>
Date: Tue, 9 Jun 2020 19:56:44 +0200
Subject: [PATCH] Fix possible view exception in pos app

Replaced string.format with a simpler replace and also allow `{Price}` instead of `{0}` as it's obscure to non c# devs
---
 BTCPayServer/Views/AppsPublic/PointOfSale/Cart.cshtml   | 2 +-
 BTCPayServer/Views/AppsPublic/PointOfSale/Static.cshtml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/BTCPayServer/Views/AppsPublic/PointOfSale/Cart.cshtml b/BTCPayServer/Views/AppsPublic/PointOfSale/Cart.cshtml
index 59072bfd2..5c0967f72 100644
--- a/BTCPayServer/Views/AppsPublic/PointOfSale/Cart.cshtml
+++ b/BTCPayServer/Views/AppsPublic/PointOfSale/Cart.cshtml
@@ -249,7 +249,7 @@
                         </div>
                         <div class="card-footer pt-0 bg-transparent border-0">
 
-                            <span class="text-muted small">@String.Format(Model.ButtonText, @item.Price.Formatted)</span>
+                            <span class="text-muted small">@Model.ButtonText.Replace("{0}",item.Price.Formatted).Replace("{Price}",item.Price.Formatted)</span>
                              @if (item.Inventory.HasValue)
                              {
 
diff --git a/BTCPayServer/Views/AppsPublic/PointOfSale/Static.cshtml b/BTCPayServer/Views/AppsPublic/PointOfSale/Static.cshtml
index 6a4c9557c..012c77de7 100644
--- a/BTCPayServer/Views/AppsPublic/PointOfSale/Static.cshtml
+++ b/BTCPayServer/Views/AppsPublic/PointOfSale/Static.cshtml
@@ -55,7 +55,7 @@
                                 {
                                     <form method="post" asp-controller="AppsPublic" asp-action="ViewPointOfSale" asp-route-appId="@Model.AppId" asp-antiforgery="false">
                                         <button type="submit" name="choiceKey" class="js-add-cart btn btn-primary" value="@item.Id">
-                                            @String.Format(Model.ButtonText, @item.Price.Formatted)
+                                            @Model.ButtonText.Replace("{0}",item.Price.Formatted).Replace("{Price}",item.Price.Formatted)
                                         </button>
                                     </form>
                                 }