From 464a29816da838e79706ae2e110f5304a2d112a8 Mon Sep 17 00:00:00 2001 From: Ruben <36157890+ubbabeck@users.noreply.github.com> Date: Fri, 12 Jan 2024 15:51:07 +0100 Subject: [PATCH] don't write ruff output to file (#121) * don't write ruff output to file * Update ruff instructions in python README --------- Co-authored-by: ok300 <106775972+ok300@users.noreply.github.com> --- .github/workflows/main.yml | 2 +- snippets/python/README.md | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4267011..3a54d0b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -263,7 +263,7 @@ jobs: - name: Check python formatting working-directory: snippets/python/src - run: ruff --ignore F841 --ignore F401 --output-format=github . + run: ruff check --ignore F841 --ignore F401 --add-noqa . - name: Check python syntax working-directory: snippets/python diff --git a/snippets/python/README.md b/snippets/python/README.md index fcbc62d..e7df224 100644 --- a/snippets/python/README.md +++ b/snippets/python/README.md @@ -14,13 +14,15 @@ cd snippets/python python3 -m compileall src ``` -To check the snippet formatting: +To check the snippet against formatting and linter rules: ```bash cd snippets/python/src -ruff --ignore F841 --ignore F401 --output-format=github . +ruff check --ignore F841 --ignore F401 --add-noqa . ``` +and fix all occurrences of the `# noqa` directive. + To execute the snippets locally, in order to check for type correctness: ```bash