mirror of
https://github.com/aljazceru/breez-lnd.git
synced 2026-01-31 12:14:32 +01:00
docs: update contribution checklist
- Update Go version 1.11 to 1.12 - Fix broken link in GitHub PR template - Fix inconsistent number of spaces after checkbox - Add proper link to "Ideal Git Commit structure"
This commit is contained in:
@@ -612,9 +612,8 @@ Rejoice as you will now be listed as a [contributor](https://github.com/lightnin
|
||||
|
||||
#### 6.1. Contribution Checklist
|
||||
|
||||
- [ ] All changes are Go version 1.11 compliant
|
||||
- [ ] The code being submitted is commented according to the
|
||||
[Code Documentation and Commenting](#CodeDocumentation) section
|
||||
- [ ] All changes are Go version 1.12 compliant
|
||||
- [ ] The code being submitted is commented according to [Code Documentation and Commenting](#CodeDocumentation)
|
||||
- [ ] For new code: Code is accompanied by tests which exercise both
|
||||
the positive and negative (error paths) conditions (if applicable)
|
||||
- [ ] For bug fixes: Code is accompanied by new tests which trigger
|
||||
@@ -632,7 +631,7 @@ Rejoice as you will now be listed as a [contributor](https://github.com/lightnin
|
||||
- [ ] All commits build properly and pass tests. Only in exceptional
|
||||
cases it can be justifiable to violate this condition. In that case, the
|
||||
reason should be stated in the commit message.
|
||||
- [ ] Commits have a logical structure (see section 4.5).
|
||||
- [ ] Commits have a logical structure according to [Ideal Git Commit Structure](#IdealGitCommitStructure).
|
||||
|
||||
<a name="Licensing" />
|
||||
|
||||
|
||||
Reference in New Issue
Block a user