From 4c402ab9d470aba23321b2ac75dcf307be2c0ad4 Mon Sep 17 00:00:00 2001
From: Conner Fromknecht <conner@lightning.engineering>
Date: Wed, 4 Mar 2020 08:00:48 -0800
Subject: [PATCH] lnwallet/size_test: refactor and expand unit tests

---
 lnwallet/size_test.go | 95 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 93 insertions(+), 2 deletions(-)

diff --git a/lnwallet/size_test.go b/lnwallet/size_test.go
index cf8cbb68..acc83b96 100644
--- a/lnwallet/size_test.go
+++ b/lnwallet/size_test.go
@@ -68,6 +68,68 @@ func TestTxWeightEstimator(t *testing.T) {
 		numP2WSHOutputs      int
 		numP2SHOutputs       int
 	}{
+		// Assert base txn size.
+		{},
+
+		// Assert single input/output sizes.
+		{
+			numP2PKHInputs: 1,
+		},
+		{
+			numP2WKHInputs: 1,
+		},
+		{
+			numP2WSHInputs: 1,
+		},
+		{
+			numNestedP2WKHInputs: 1,
+		},
+		{
+			numNestedP2WSHInputs: 1,
+		},
+		{
+			numP2WKHOutputs: 1,
+		},
+		{
+			numP2PKHOutputs: 1,
+		},
+		{
+			numP2WSHOutputs: 1,
+		},
+		{
+			numP2SHOutputs: 1,
+		},
+
+		// Assert each input/output increments input/output counts.
+		{
+			numP2PKHInputs: 253,
+		},
+		{
+			numP2WKHInputs: 253,
+		},
+		{
+			numP2WSHInputs: 253,
+		},
+		{
+			numNestedP2WKHInputs: 253,
+		},
+		{
+			numNestedP2WSHInputs: 253,
+		},
+		{
+			numP2WKHOutputs: 253,
+		},
+		{
+			numP2PKHOutputs: 253,
+		},
+		{
+			numP2WSHOutputs: 253,
+		},
+		{
+			numP2SHOutputs: 253,
+		},
+
+		// Assert basic combinations of inputs and outputs.
 		{
 			numP2PKHInputs:  1,
 			numP2PKHOutputs: 2,
@@ -97,13 +159,42 @@ func TestTxWeightEstimator(t *testing.T) {
 			numP2SHOutputs: 1,
 		},
 		{
-			numNestedP2WKHInputs: 253,
+			numNestedP2WKHInputs: 1,
 			numP2WKHOutputs:      1,
 		},
 		{
-			numNestedP2WSHInputs: 253,
+			numNestedP2WSHInputs: 1,
 			numP2WKHOutputs:      1,
 		},
+
+		// Assert disparate input/output types increment total
+		// input/output counts.
+		{
+			numP2PKHInputs:       50,
+			numP2WKHInputs:       50,
+			numP2WSHInputs:       51,
+			numNestedP2WKHInputs: 51,
+			numNestedP2WSHInputs: 51,
+			numP2WKHOutputs:      1,
+		},
+		{
+			numP2WKHInputs:  1,
+			numP2WKHOutputs: 63,
+			numP2PKHOutputs: 63,
+			numP2WSHOutputs: 63,
+			numP2SHOutputs:  64,
+		},
+		{
+			numP2PKHInputs:       50,
+			numP2WKHInputs:       50,
+			numP2WSHInputs:       51,
+			numNestedP2WKHInputs: 51,
+			numNestedP2WSHInputs: 51,
+			numP2WKHOutputs:      63,
+			numP2PKHOutputs:      63,
+			numP2WSHOutputs:      63,
+			numP2SHOutputs:       64,
+		},
 	}
 
 	for i, test := range testCases {