aljaz/breez-lnd
1
0
Fork 0
mirror of https://github.com/aljazceru/breez-lnd.git synced 2025-12-17 06:04:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5697 from arshbot/export-selectHopHints

Browse Source 
invoicesrpc: expose selectHopHints
This commit is contained in:
Oliver Gugger
2021-09-08 10:27:36 +02:00
committed by GitHub
parent 75f5b407ea 8720b8f657
commit 4337116bce
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
docs/release-notes/release-notes-0.14.0.md
View File

@@ -152,6 +152,10 @@ you.
into projects that are compiled to WASM binaries. [That problem was fixed by into projects that are compiled to WASM binaries. [That problem was fixed by
guarding those syscalls with build tags](https://github.com/lightningnetwork/lnd/pull/5526). guarding those syscalls with build tags](https://github.com/lightningnetwork/lnd/pull/5526).
* The only way to retrieve hophints for a given node was to create an invoice
with the `addInvoice` rpc interface. However, now the function has been
[exposed in the go package `invoicesrpc`](https://github.com/lightningnetwork/lnd/pull/5697).
## Code Health ## Code Health
### Code cleanup, refactor, typo fixes ### Code cleanup, refactor, typo fixes
@@ -265,6 +269,7 @@ change](https://github.com/lightningnetwork/lnd/pull/5613).
* de6df1re * de6df1re
* ErikEk * ErikEk
* Eugene Siegel * Eugene Siegel
* Harsha Goli
* Martin Habovstiak * Martin Habovstiak
* Oliver Gugger * Oliver Gugger
* Wilmer Paulino * Wilmer Paulino

6
lnrpc/invoicesrpc/addinvoice.go
View File

@@ -391,7 +391,7 @@ func AddInvoice(ctx context.Context, cfg *AddInvoiceConfig,
// We'll restrict the number of individual route hints // We'll restrict the number of individual route hints
// to 20 to avoid creating overly large invoices. // to 20 to avoid creating overly large invoices.
numMaxHophints := 20 - len(forcedHints) numMaxHophints := 20 - len(forcedHints)
hopHints := selectHopHints( hopHints := SelectHopHints(
amtMSat, cfg, filteredChannels, numMaxHophints, amtMSat, cfg, filteredChannels, numMaxHophints,
) )
@@ -553,12 +553,12 @@ func addHopHint(hopHints *[]func(*zpay32.Invoice),
) )
} }
// selectHopHints will select up to numMaxHophints from the set of passed open // SelectHopHints will select up to numMaxHophints from the set of passed open
// channels. The set of hop hints will be returned as a slice of functional // channels. The set of hop hints will be returned as a slice of functional
// options that'll append the route hint to the set of all route hints. // options that'll append the route hint to the set of all route hints.
// //
// TODO(roasbeef): do proper sub-set sum max hints usually << numChans // TODO(roasbeef): do proper sub-set sum max hints usually << numChans
func selectHopHints(amtMSat lnwire.MilliSatoshi, cfg *AddInvoiceConfig, func SelectHopHints(amtMSat lnwire.MilliSatoshi, cfg *AddInvoiceConfig,
openChannels []*channeldb.OpenChannel, openChannels []*channeldb.OpenChannel,
numMaxHophints int) []func(*zpay32.Invoice) { numMaxHophints int) []func(*zpay32.Invoice) {