aljaz/boris
1
1
Fork 0
mirror of https://github.com/dergigi/boris.git synced 2025-12-18 15:14:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: handle empty d-tags separately in bookmark hydration

Browse Source 
Separate fetching of articles with empty vs non-empty d-tags to work
around relay filter handling issues. For empty d-tags, fetch all events
of that kind/author and filter client-side.
This commit is contained in:
Gigi
2025-10-22 11:25:30 +02:00
parent 3f82bc7873
commit e40f820fdc
1 changed files with 60 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

81
src/services/bookmarkController.ts
View File

@@ -197,30 +197,69 @@ class BookmarkController {
// Fetch each group // Fetch each group
for (const [kind, byPubkey] of filtersByKind) { for (const [kind, byPubkey] of filtersByKind) {
for (const [pubkey, identifiers] of byPubkey) { for (const [pubkey, identifiers] of byPubkey) {
console.log('[BookmarkController] Fetching kind', kind, 'from pubkey', pubkey.slice(0, 8), 'with', identifiers.length, 'identifiers:', identifiers) // Separate empty and non-empty identifiers
await queryEvents( const nonEmptyIdentifiers = identifiers.filter(id => id && id.length > 0)
this.relayPool, const hasEmptyIdentifier = identifiers.some(id => !id || id.length === 0)
{ kinds: [kind], authors: [pubkey], '#d': identifiers },
{ console.log('[BookmarkController] Fetching kind', kind, 'from pubkey', pubkey.slice(0, 8), 'with', identifiers.length, 'identifiers:', identifiers, '(non-empty:', nonEmptyIdentifiers.length, 'empty:', hasEmptyIdentifier, ')')
onEvent: (event) => {
// Check if hydration was cancelled // Fetch events with non-empty d-tags
if (this.hydrationGeneration !== generation) return if (nonEmptyIdentifiers.length > 0) {
await queryEvents(
this.relayPool,
{ kinds: [kind], authors: [pubkey], '#d': nonEmptyIdentifiers },
{
onEvent: (event) => {
// Check if hydration was cancelled
if (this.hydrationGeneration !== generation) return
const dTag = event.tags?.find((t: string[]) => t[0] === 'd')?.[1] || '' const dTag = event.tags?.find((t: string[]) => t[0] === 'd')?.[1] || ''
const coordinate = `${event.kind}:${event.pubkey}:${dTag}` const coordinate = `${event.kind}:${event.pubkey}:${dTag}`
console.log('[BookmarkController] Hydrated article:', coordinate, getArticleTitle(event) || 'No title') console.log('[BookmarkController] Hydrated article (non-empty d):', coordinate, getArticleTitle(event) || 'No title')
idToEvent.set(coordinate, event) idToEvent.set(coordinate, event)
idToEvent.set(event.id, event) idToEvent.set(event.id, event)
// Add to external event store if available // Add to external event store if available
if (this.externalEventStore) { if (this.externalEventStore) {
this.externalEventStore.add(event) this.externalEventStore.add(event)
}
onProgress()
} }
onProgress()
} }
} )
) }
// Fetch events with empty d-tag separately (without '#d' filter)
if (hasEmptyIdentifier) {
console.log('[BookmarkController] Fetching events with empty d-tag for kind', kind, 'pubkey', pubkey.slice(0, 8))
await queryEvents(
this.relayPool,
{ kinds: [kind], authors: [pubkey] },
{
onEvent: (event) => {
// Check if hydration was cancelled
if (this.hydrationGeneration !== generation) return
// Only process events with empty d-tag
const dTag = event.tags?.find((t: string[]) => t[0] === 'd')?.[1] || ''
if (dTag !== '') return
const coordinate = `${event.kind}:${event.pubkey}:`
console.log('[BookmarkController] Hydrated article (empty d):', coordinate, getArticleTitle(event) || 'No title')
idToEvent.set(coordinate, event)
idToEvent.set(event.id, event)
// Add to external event store if available
if (this.externalEventStore) {
this.externalEventStore.add(event)
}
onProgress()
}
}
)
}
} }
} }
console.log('[BookmarkController] Coordinate hydration complete') console.log('[BookmarkController] Coordinate hydration complete')