refactor: remove redundant isLocalOnly flag

- Remove isLocalOnly field from Highlight type and creation logic
- Use only isOfflineCreated flag for flight mode highlights
- Simplify UI logic to check only isOfflineCreated
- Both flags were set to the same value, making them redundant
- Cleaner, more maintainable code with single source of truth

src/components/HighlightItem.tsx

@@ -307,7 +307,7 @@ export const HighlightItem: React.FC<HighlightItemProps> = ({
     }
     
     // Check if this highlight was created offline (flight mode)
-    const isOfflineCreated = highlight.isOfflineCreated || highlight.isLocalOnly
+    const isOfflineCreated = highlight.isOfflineCreated
     
     // Show highlighter icon with relay info if available
     if (highlight.publishedRelays && highlight.publishedRelays.length > 0) {

src/services/highlightCreationService.ts

@@ -135,7 +135,6 @@ export async function createHighlight(
   // Convert to Highlight with relay tracking info and return IMMEDIATELY
   const highlight = eventToHighlight(signedEvent)
   highlight.publishedRelays = expectedSuccessRelays
-  highlight.isLocalOnly = isLocalOnly
   highlight.isOfflineCreated = isLocalOnly
 
   return highlight

src/types/highlights.ts

@@ -15,10 +15,9 @@ export interface Highlight {
   comment?: string // optional comment about the highlight
   // Level classification (computed based on user's context)
   level?: HighlightLevel
-  // Relay tracking for offline/local-only highlights
+  // Relay tracking for offline highlights
   publishedRelays?: string[] // URLs of relays where this was published (for user-created highlights)
   seenOnRelays?: string[] // URLs of relays where this event was fetched from
-  isLocalOnly?: boolean // true if only published to local relays
   isOfflineCreated?: boolean // true if created while in flight mode (offline)
   isSyncing?: boolean // true if currently being synced to remote relays
 }