aljaz/boris
1
1
Fork 0
mirror of https://github.com/dergigi/boris.git synced 2025-12-17 06:34:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove unnecessary label comparison and fix useEffect dependencies

Browse Source
This commit is contained in:
Gigi
2025-11-02 21:06:40 +01:00
parent 074af764ed
commit d206ff228e
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/hooks/useProfileLabels.ts
View File

@@ -166,11 +166,7 @@ export function useProfileLabels(content: string, relayPool?: RelayPool | null):
// Update labels with what we found in localStorage cache and eventStore // Update labels with what we found in localStorage cache and eventStore
const initialResolveTime = Date.now() - startTime const initialResolveTime = Date.now() - startTime
console.log(`[${ts()}] [npub-resolve] Initial resolution complete:`, labels.size, 'labels resolved in', initialResolveTime, 'ms. Will fetch', pubkeysToFetch.length, 'missing profiles.') console.log(`[${ts()}] [npub-resolve] Initial resolution complete:`, labels.size, 'labels resolved in', initialResolveTime, 'ms. Will fetch', pubkeysToFetch.length, 'missing profiles.')
// Only update if labels changed (avoid unnecessary re-renders)
if (labels.size !== profileLabels.size || Array.from(labels.keys()).some(k => labels.get(k) !== profileLabels.get(k))) {
setProfileLabels(new Map(labels)) setProfileLabels(new Map(labels))
}
// Fetch missing profiles asynchronously // Fetch missing profiles asynchronously
if (pubkeysToFetch.length > 0 && relayPool && eventStore) { if (pubkeysToFetch.length > 0 && relayPool && eventStore) {
@@ -250,9 +246,7 @@ export function useProfileLabels(content: string, relayPool?: RelayPool | null):
console.error(`[${ts()}] [npub-resolve] Error fetching profiles after`, fetchDuration, 'ms:', err) console.error(`[${ts()}] [npub-resolve] Error fetching profiles after`, fetchDuration, 'ms:', err)
}) })
} }
// eslint-disable-next-line react-hooks/exhaustive-deps }, [profileData, eventStore, relayPool, initialLabels])
// initialLabels is derived from profileData, profileLabels is state we update (would cause loops)
}, [profileData, eventStore, relayPool])
// Only log when size actually changes to reduce noise // Only log when size actually changes to reduce noise
useEffect(() => { useEffect(() => {