aljaz/boris
1
1
Fork 0
mirror of https://github.com/dergigi/boris.git synced 2025-12-18 07:04:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove isMounted from useEffect dependencies

Browse Source 
- isMounted is a stable function from useMountedState and shouldn't be in deps
- Including it was preventing effects from running correctly
- Fixes issue where articles wouldn't load (stuck on spinner)
This commit is contained in:
Gigi
2025-10-20 17:46:41 +02:00
parent 627ffd6c5d
commit b117b1e6cf
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/hooks/useArticleLoader.ts
View File

@@ -116,6 +116,7 @@ export function useArticleLoader({
loadArticle() loadArticle()
// Intentionally excluding setter functions from dependencies to prevent race conditions // Intentionally excluding setter functions from dependencies to prevent race conditions
// isMounted is a stable function and doesn't need to be in dependencies
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps
}, [naddr, relayPool, settings, isMounted]) }, [naddr, relayPool, settings])
} }

3
src/hooks/useExternalUrlLoader.ts
View File

@@ -150,8 +150,9 @@ export function useExternalUrlLoader({
loadExternalUrl() loadExternalUrl()
// Intentionally excluding setter functions from dependencies to prevent race conditions // Intentionally excluding setter functions from dependencies to prevent race conditions
// isMounted is a stable function and doesn't need to be in dependencies
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps
}, [url, relayPool, eventStore, cachedUrlHighlights, isMounted]) }, [url, relayPool, eventStore, cachedUrlHighlights])
// Keep UI highlights synced with cached store updates without reloading content // Keep UI highlights synced with cached store updates without reloading content
useEffect(() => { useEffect(() => {