From 572f0fed6fddc1e222dd5fd2d2d8f5327e9114e4 Mon Sep 17 00:00:00 2001 From: Gigi Date: Mon, 20 Oct 2025 10:14:20 +0200 Subject: [PATCH] fix(reads/links): keep DRY filtering but enforce type separation (articles vs external) for /me/reads and /me/links filters --- src/components/Me.tsx | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/components/Me.tsx b/src/components/Me.tsx index 02550b00..7a71338b 100644 --- a/src/components/Me.tsx +++ b/src/components/Me.tsx @@ -620,9 +620,17 @@ const Me: React.FC = ({ return item }) - // Apply reading progress filter - const filteredReads = filterByReadingProgress(readsWithProgress, readingProgressFilter, highlights) - const filteredLinks = filterByReadingProgress(linksWithProgress, readingProgressFilter, highlights) + // Apply reading progress filter with simple type separation to keep Views distinct and DRY + const filteredReads = filterByReadingProgress( + readsWithProgress.filter(item => item.type === 'article'), + readingProgressFilter, + highlights + ) + const filteredLinks = filterByReadingProgress( + linksWithProgress.filter(item => item.type === 'external'), + readingProgressFilter, + highlights + ) const sections: Array<{ key: string; title: string; items: IndividualBookmark[] }> = groupingMode === 'flat' ? [{ key: 'all', title: `All Bookmarks (${filteredBookmarks.length})`, items: filteredBookmarks }]