From 4e869076635b810232958893f353e7c7c64743f5 Mon Sep 17 00:00:00 2001 From: Gigi Date: Mon, 20 Oct 2025 13:41:45 +0200 Subject: [PATCH] fix: apply hideBookmarksWithoutCreationDate setting to Me component - Import hasCreationDate utility function in Me.tsx - Add UserSettings to MeProps interface - Pass settings prop from Bookmarks to Me component - Filter out bookmarks without creation dates when setting is enabled - This ensures bookmarks showing 'Now' are hidden by default --- src/components/Bookmarks.tsx | 2 +- src/components/Me.tsx | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/components/Bookmarks.tsx b/src/components/Bookmarks.tsx index 15fe56c5..1c2efa13 100644 --- a/src/components/Bookmarks.tsx +++ b/src/components/Bookmarks.tsx @@ -328,7 +328,7 @@ const Bookmarks: React.FC = ({ relayPool ? : null ) : undefined} me={showMe ? ( - relayPool ? : null + relayPool ? : null ) : undefined} profile={showProfile && profilePubkey ? ( relayPool ? : null diff --git a/src/components/Me.tsx b/src/components/Me.tsx index e464535d..1097379e 100644 --- a/src/components/Me.tsx +++ b/src/components/Me.tsx @@ -23,7 +23,7 @@ import { getCachedMeData, updateCachedHighlights } from '../services/meCache' import { faBooks } from '../icons/customIcons' import { usePullToRefresh } from 'use-pull-to-refresh' import RefreshIndicator from './RefreshIndicator' -import { groupIndividualBookmarks, hasContent } from '../utils/bookmarkUtils' +import { groupIndividualBookmarks, hasContent, hasCreationDate } from '../utils/bookmarkUtils' import BookmarkFilters, { BookmarkFilterType } from './BookmarkFilters' import { filterBookmarksByType } from '../utils/bookmarkTypeClassifier' import ReadingProgressFilters, { ReadingProgressFilterType } from './ReadingProgressFilters' @@ -31,6 +31,7 @@ import { filterByReadingProgress } from '../utils/readingProgressUtils' import { deriveLinksFromBookmarks } from '../utils/linksFromBookmarks' import { readingProgressController } from '../services/readingProgressController' import { archiveController } from '../services/archiveController' +import { UserSettings } from '../services/settingsService' interface MeProps { relayPool: RelayPool @@ -38,6 +39,7 @@ interface MeProps { activeTab?: TabType bookmarks: Bookmark[] // From centralized App.tsx state bookmarksLoading?: boolean // From centralized App.tsx state (reserved for future use) + settings: UserSettings } type TabType = 'highlights' | 'reading-list' | 'reads' | 'links' | 'writings' @@ -49,7 +51,8 @@ const Me: React.FC = ({ relayPool, eventStore, activeTab: propActiveTab, - bookmarks + bookmarks, + settings }) => { const activeAccount = Hooks.useActiveAccount() const navigate = useNavigate() @@ -489,6 +492,7 @@ const Me: React.FC = ({ // Merge and flatten all individual bookmarks const allIndividualBookmarks = bookmarks.flatMap(b => b.individualBookmarks || []) .filter(hasContent) + .filter(b => !settings?.hideBookmarksWithoutCreationDate || hasCreationDate(b)) // Apply bookmark filter const filteredBookmarks = filterBookmarksByType(allIndividualBookmarks, bookmarkFilter)