mirror of
https://github.com/dergigi/boris.git
synced 2025-12-18 07:04:19 +01:00
fix: remove eventStore and setter functions from useEffect dependencies
- Remove eventStore from useArticleLoader and useExternalUrlLoader dependencies - Remove setter functions from dependencies as they shouldn't change - Only keep naddr/url and previewData/cachedUrlHighlights as dependencies - This prevents content loaders from re-running when going offline - Fixes the core issue where loading skeleton appears immediately on offline detection
This commit is contained in:
@@ -317,16 +317,6 @@ export function useArticleLoader({
|
||||
}
|
||||
}, [
|
||||
naddr,
|
||||
eventStore,
|
||||
previewData,
|
||||
setSelectedUrl,
|
||||
setReaderContent,
|
||||
setReaderLoading,
|
||||
setIsCollapsed,
|
||||
setHighlights,
|
||||
setHighlightsLoading,
|
||||
setCurrentArticleCoordinate,
|
||||
setCurrentArticleEventId,
|
||||
setCurrentArticle
|
||||
previewData
|
||||
])
|
||||
}
|
||||
|
||||
@@ -167,16 +167,7 @@ export function useExternalUrlLoader({
|
||||
}
|
||||
}, [
|
||||
url,
|
||||
eventStore,
|
||||
cachedUrlHighlights,
|
||||
setReaderContent,
|
||||
setReaderLoading,
|
||||
setIsCollapsed,
|
||||
setSelectedUrl,
|
||||
setHighlights,
|
||||
setCurrentArticleCoordinate,
|
||||
setCurrentArticleEventId,
|
||||
setHighlightsLoading
|
||||
cachedUrlHighlights
|
||||
])
|
||||
|
||||
// Keep UI highlights synced with cached store updates without reloading content
|
||||
|
||||
Reference in New Issue
Block a user