fix: add comments to empty catch blocks to satisfy linter

This commit is contained in:
Gigi
2025-10-22 09:00:01 +02:00
parent c7b885cfcd
commit 0be6aa81ce
5 changed files with 24 additions and 6 deletions

View File

@@ -2,4 +2,4 @@
alwaysApply: true alwaysApply: true
--- ---
Keep files below 210 lines. Keep files below 420 lines.

View File

@@ -0,0 +1,18 @@
---
description: fetching data from relays
alwaysApply: false
---
We fetch data from relays using controllers:
- Start controllers immediatly; dont await.
- Stream via onEvent; dedupe replaceables; emit immediately.
- Parallel local/remote queries; complete on EOSE.
- Finalize and persist since after completion.
- Guard with generations to cancel stale runs.
- UI flips off loading on first streamed result.
We always include and prefer local relays for reads; optionally rebroadcast fetched content to local relays (depending on setting); and tolerate localonly mode for writes (queueing for later).
Since we are streaming results, we should NEVER use timeouts for fetching data. We should always rely on EOSE.
In short: Local-first hydration, background network fetch, reactive updates, and replaceable lookups provide instant UI with eventual consistency. Use local relays as local data store for everything we fetch from remote relays.

View File

@@ -790,7 +790,7 @@ const Debug: React.FC<DebugProps> = ({
const keys = Array.from(progressMap.keys()) const keys = Array.from(progressMap.keys())
const sample = keys.slice(0, 5).join(', ') const sample = keys.slice(0, 5).join(', ')
DebugBus.info('debug', `Progress keys sample: ${sample}`) DebugBus.info('debug', `Progress keys sample: ${sample}`)
} catch {} } catch { /* ignore */ }
}) })
// Run both in parallel // Run both in parallel

View File

@@ -173,8 +173,8 @@ export function startReadingPositionStream(
// Caller manages lifecycle // Caller manages lifecycle
return () => { return () => {
try { storeSub.unsubscribe() } catch {} try { storeSub.unsubscribe() } catch { /* ignore */ }
try { networkSub.unsubscribe() } catch {} try { networkSub.unsubscribe() } catch { /* ignore */ }
} }
} }

View File

@@ -111,8 +111,8 @@ export function startSettingsStream(
// Caller manages lifecycle // Caller manages lifecycle
return () => { return () => {
try { storeSub.unsubscribe() } catch {} try { storeSub.unsubscribe() } catch { /* ignore */ }
try { networkSub.unsubscribe() } catch {} try { networkSub.unsubscribe() } catch { /* ignore */ }
} }
} }