refactor(components): improve type safety and simplify IconButton

- Add proper type guards in ContentWithResolvedProfiles to avoid type assertions
- Remove href/link functionality from IconButton component for simplification
- Replace 'as any' with proper type narrowing using type predicates

src/components/ContentWithResolvedProfiles.tsx

@@ -11,17 +11,19 @@ const ContentWithResolvedProfiles: React.FC<Props> = ({ content }) => {
   const matches = extractNprofilePubkeys(content)
   const decoded = matches
     .map((m) => {
-      try { return decode(m) } catch { return undefined }
+      try { return decode(m) } catch { return undefined as undefined }
     })
-    .filter(Boolean)
+    .filter((v): v is ReturnType<typeof decode> => Boolean(v))
 
-  const lookups = decoded.map((res) => getPubkeyFromDecodeResult(res as any)).filter(Boolean) as string[]
+  const lookups = decoded
+    .map((res) => getPubkeyFromDecodeResult(res))
+    .filter((v): v is string => typeof v === 'string')
 
   const profiles = lookups.map((pubkey) => ({ pubkey, profile: useEventModel(Models.ProfileModel, [pubkey]) }))
 
   let rendered = content
   matches.forEach((m, i) => {
-    const pk = getPubkeyFromDecodeResult(decoded[i] as any)
+    const pk = getPubkeyFromDecodeResult(decoded[i])
     const found = profiles.find((p) => p.pubkey === pk)
     const name = found?.profile?.name || found?.profile?.display_name || found?.profile?.nip05 || `${pk?.slice(0,8)}...`
     if (name) rendered = rendered.replace(m, `@${name}`)

src/components/IconButton.tsx

@@ -9,9 +9,6 @@ interface IconButtonProps {
   ariaLabel?: string
   variant?: 'primary' | 'success' | 'ghost'
   size?: number
-  href?: string
-  target?: string
-  rel?: string
 }
 
 const IconButton: React.FC<IconButtonProps> = ({
@@ -20,35 +17,15 @@ const IconButton: React.FC<IconButtonProps> = ({
   title,
   ariaLabel,
   variant = 'ghost',
-  size = 44,
-  href,
-  target,
-  rel
+  size = 44
 }) => {
-  const commonProps = {
-    className: `icon-button ${variant}`,
-    title,
-    'aria-label': ariaLabel || title,
-    style: { width: size, height: size }
-  } as const
-
-  if (href) {
-    return (
-      <a
-        {...(commonProps as any)}
-        href={href}
-        target={target || '_blank'}
-        rel={rel || 'noopener noreferrer'}
-      >
-        <FontAwesomeIcon icon={icon} />
-      </a>
-    )
-  }
-
   return (
     <button
-      {...(commonProps as any)}
+      className={`icon-button ${variant}`}
       onClick={onClick}
+      title={title}
+      aria-label={ariaLabel || title}
+      style={{ width: size, height: size }}
     >
       <FontAwesomeIcon icon={icon} />
     </button>